linux-kernel - Re: [PATCH v5 2/2] RDMA/srp: Fix error return code in srp_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <feecdae4-6a50-5991-5792-eda44c0a641b@acm.org>
Date:   Fri, 2 Dec 2022 15:06:35 -0800
From:   Bart Van Assche <bvanassche@....org>
To:     Wang Yufen <wangyufen@...wei.com>, jgg@...pe.ca, leon@...nel.org,
        dennis.dalessandro@...nelisnetworks.com
Cc:     linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        andriy.shevchenko@...ux.intel.com, bart.vanassche@....com,
        easwar.hariharan@...el.com
Subject: Re: [PATCH v5 2/2] RDMA/srp: Fix error return code in
 srp_parse_options()

On 12/1/22 20:00, Wang Yufen wrote:
> In the previous iteration of the while loop, the "ret" may have been
> assigned a value of 0, so the error return code -EINVAL may have been
> incorrectly set to 0. To fix set valid return code before calling to
> goto. Also investigate each case separately as Andy suggessted.

Reviewed-by: Bart Van Assche <bvanassche@....org>