linux-kernel - [PATCH linux-next v2] pxa: Remove dev_err() after platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202212021042043546303@zte.com.cn>
Date:   Fri, 2 Dec 2022 10:42:04 +0800 (CST)
From:   <zhang.songyi@....com.cn>
To:     <soc@...nel.org>, <arnd@...db.de>
Cc:     <zhang.songyi@....com.cn>, <robert.jarzmik@...e.fr>,
        <lkundrak@...sk>, <linux-kernel@...r.kernel.org>
Subject: [PATCH linux-next v2] pxa: Remove dev_err() after platform_get_irq()

From: zhang songyi <zhang.songyi@....com.cn>

There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.

Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
Reviewed-by: Lubomir Rintel <lkundrak@...sk>
---
 drivers/soc/pxa/ssp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/pxa/ssp.c b/drivers/soc/pxa/ssp.c
index 93449fb3519e..bd029e838241 100644
--- a/drivers/soc/pxa/ssp.c
+++ b/drivers/soc/pxa/ssp.c
@@ -146,10 +146,8 @@ static int pxa_ssp_probe(struct platform_device *pdev)
 	}

 	ssp->irq = platform_get_irq(pdev, 0);
-	if (ssp->irq < 0) {
-		dev_err(dev, "no IRQ resource defined\n");
+	if (ssp->irq < 0)
 		return -ENODEV;
-	}

 	if (dev->of_node) {
 		const struct of_device_id *id =
-- 
2.15.2