linux-kernel - Re: [PATCH v3 2/3] net: dsa: hellcreek: Check return value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6yes0jn.fsf@kurt>
Date:   Fri, 02 Dec 2022 08:54:36 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Artem Chernyshev <artem.chernyshev@...-soft.ru>,
        artem.chernyshev@...-soft.ru, Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        lvc-project@...uxtesting.org
Subject: Re: [PATCH v3 2/3] net: dsa: hellcreek: Check return value

On Thu Dec 01 2022, Artem Chernyshev wrote:
> Return NULL if we got unexpected value from skb_trim_rcsum() 
                                              ^ pskb_trim_rcsum()
> in hellcreek_rcv()

For the next time, a change log should rather explain *why* a change is
made instead of *what* the patch is doing.

Other than that,

Reviewed-by: Kurt Kanzenbach <kurt@...utronix.de>

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)