linux-kernel - Re: [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4mzc7DieBNrYBpy@google.com>
Date:   Fri, 2 Dec 2022 08:12:35 +0000
From:   Lee Jones <lee@...nel.org>
To:     Jesse Taube <mr.bossman075@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
        lee.jones@...aro.org
Subject: Re: [PATCH v1] drivers/mfd: simple-mfd-i2c: Add generic compatible

On Wed, 30 Nov 2022, Jesse Taube wrote:

> Some devices may want to use this driver without having a specific
> compatible string. Add a generic compatible string to allow this.

I actually really like this idea.

Perhaps kontron,sl28cpld could also be converted too.

Please reverse the nomenclature though:

  simple-mfd-i2c-generic

> Signed-off-by: Jesse Taube <Mr.Bossman075@...il.com>
> ---
>  drivers/mfd/simple-mfd-i2c.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c
> index f4c8fc3ee463..cf2829f703e2 100644
> --- a/drivers/mfd/simple-mfd-i2c.c
> +++ b/drivers/mfd/simple-mfd-i2c.c
> @@ -73,6 +73,7 @@ static const struct simple_mfd_data silergy_sy7636a = {
>  };
>  
>  static const struct of_device_id simple_mfd_i2c_of_match[] = {
> +	{ .compatible = "generic-simple-mfd-i2c" },
>  	{ .compatible = "kontron,sl28cpld" },
>  	{ .compatible = "silergy,sy7636a", .data = &silergy_sy7636a},
>  	{}

-- 
Lee Jones [李琼斯]