linux-kernel - Re: [PATCH v2] media: platform: mtk-mdp3: Fix return value check in mdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4f4b9ff6-73e3-a8b3-1d1c-e1d0a0b9b38c@xs4all.nl>
Date:   Fri, 2 Dec 2022 09:42:59 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Qiheng Lin <linqiheng@...wei.com>, mchehab@...nel.org,
        matthias.bgg@...il.com
Cc:     angelogioacchino.delregno@...labora.com,
        linux-media@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] media: platform: mtk-mdp3: Fix return value check in
 mdp_probe()

Hi Qiheng,

Can you rebase on top of the latest staging tree? (https://git.linuxtv.org/media_stage.git/)

This patch no longer applies.

Thanks!

	Hans

On 01/12/2022 03:35, Qiheng Lin wrote:
> In case of error, the function mtk_mutex_get()
> returns ERR_PTR() and never returns NULL. The NULL test in the
> return value check should be replaced with IS_ERR().
> And also fix the err_return case.
> 
> Fixes: 61890ccaefaf ("media: platform: mtk-mdp3: add MediaTek MDP3 driver")
> Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> ---
> 
> v2:
>  - Add fix the err_return case.
> 
>  drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> index c413e59d4286..48f3e32fe54e 100644
> --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c
> @@ -207,8 +207,8 @@ static int mdp_probe(struct platform_device *pdev)
>  	}
>  	for (i = 0; i < MDP_PIPE_MAX; i++) {
>  		mdp->mdp_mutex[i] = mtk_mutex_get(&mm_pdev->dev);
> -		if (!mdp->mdp_mutex[i]) {
> -			ret = -ENODEV;
> +		if (IS_ERR(mdp->mdp_mutex[i])) {
> +			ret = PTR_ERR(mdp->mdp_mutex[i]);
>  			goto err_return;
>  		}
>  	}
> @@ -288,9 +288,10 @@ static int mdp_probe(struct platform_device *pdev)
>  err_deinit_comp:
>  	mdp_comp_destroy(mdp);
>  err_return:
> -	for (i = 0; i < MDP_PIPE_MAX; i++)
> -		if (mdp)
> -			mtk_mutex_put(mdp->mdp_mutex[i]);
> +	if (mdp)
> +		for (i = 0; i < MDP_PIPE_MAX; i++)
> +			if (!IS_ERR_OR_NULL(mdp->mdp_mutex[i]))
> +				mtk_mutex_put(mdp->mdp_mutex[i]);
>  	kfree(mdp);
>  	dev_dbg(dev, "Errno %d\n", ret);
>  	return ret;