linux-kernel - Regression in dmaengine/next was removed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221202112003.kanwr7bixbaiqdgz@pengutronix.de>
Date:   Fri, 2 Dec 2022 12:20:03 +0100
From:   Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Arnd Bergmann <arnd@...nel.org>,
        linux-samsung-soc@...r.kernel.org, Ben Dooks <ben-linux@...ff.org>,
        linux-kernel@...r.kernel.org,
        Simtec Linux Team <linux@...tec.co.uk>,
        linux-next@...r.kernel.org, Alim Akhtar <alim.akhtar@...sung.com>,
        dmaengine@...r.kernel.org, kernel@...gutronix.de
Subject: Regression in dmaengine/next was removed

Hello,

I made the subject a bit more expressive.

On Fri, Nov 25, 2022 at 09:52:51AM +0100, Krzysztof Kozlowski wrote:
> On 25/11/2022 09:51, Uwe Kleine-König wrote:
> > On Sun, Nov 20, 2022 at 12:22:31PM +0100, Krzysztof Kozlowski wrote:
> >> On 20/11/2022 11:31, Krzysztof Kozlowski wrote:
> >>> On 18/11/2022 22:54, Uwe Kleine-König wrote:
> >>>> The linux/platform_data/dma-s3c24xx.h header file was removed. It didn't
> >>>> declare or define any symbol needed in devs.c though, so the #include
> >>>> can just be dropped.
> >>>>
> >>>> Fixes: cccc46ae3623 ("dmaengine: remove s3c24xx driver")
> >>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> >>>> ---
> >>>
> >>> The file was not removed... or it should not have been yet. The s3c24xx
> >>> dma driver removal should be part of Arnd series taken via SoC ARM.
> > 
> > The patch enters next with the merge of
> > 
> > 	git://git.kernel.org/pub/scm/linux/kernel/git/vkoul/dmaengine.git next
> > 
> > Ah, the patch that became cccc46ae3623 (i.e. patch #14) is part of a
> > bigger series. Its patch #1 removes s3c24xx.c (which you pointed out to be still
> > broken) and patch #2 includes the change I suggested here.
> > 
> >> I think that commit should be just dropped instead.
> > 
> > +1
> > 
> > BTW, cccc46ae3623 is included in next since next-20221107 and breaks
> > (at least) arm/s3c2410_defconfig. So I would consider reverting
> > cccc46ae3623 a fix. (Added linux-next to Cc:)
> 
> Yes. The build failure of next was reported already by kernel test robot.
> 
> Vinod, can we drop this patch?

That patch is still contained in the next tags of this week. :-(

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)