linux-kernel - Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA string ordering in /proc/cpuinfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4njhrGft++1rVRj@spud>
Date:   Fri, 2 Dec 2022 11:37:42 +0000
From:   Conor Dooley <conor@...nel.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     Conor Dooley <conor.dooley@...rochip.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        linux-riscv@...ts.infradead.org, ajones@...tanamicro.com,
        aou@...s.berkeley.edu, corbet@....net, guoren@...nel.org,
        heiko@...ech.de, paul.walmsley@...ive.com,
        linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v1 3/3] Documentation: riscv: add a section about ISA
 string ordering in /proc/cpuinfo

On Fri, Dec 02, 2022 at 09:14:08AM +0700, Bagas Sanjaya wrote:
> On 12/1/22 15:17, Conor Dooley wrote:
> > On Thu, Dec 01, 2022 at 10:05:32AM +0700, Bagas Sanjaya wrote:
> >> On Wed, Nov 30, 2022 at 11:41:26PM +0000, Conor Dooley wrote:
> >>> +#. Single-letter extensions come first, in "canonical order", so
> >>> +   "IMAFDQLCBKJTPVH".
> >>
> >> "..., that is ... ."
> > 
> > Hmm, that reads strangely to me. s/that/which/.
> > 
> 
> OK.
> 
> >>
> >>> +#. The first letter following the 'Z' conventionally indicates the most
> >>> +   closely related alphabetical extension category, IMAFDQLCBKJTPVH.
> >>> +   If multiple 'Z' extensions are named, they should be ordered first by
> >>> +   category, then alphabetically within a category.
> >>> +
> >>
> >> Did you mean "most closely related alphabetical extension category in
> >> canonical order"?
> > 
> > I am not 100% sure what you are suggesting a replacement of here. I
> > think I may reword this as:
> >   For additional standard extensions, the first letter following the 'Z'
> >   conventionally indicates the most closely related alphabetical
> >   extension category. If multiple 'Z' extensions are named, they will
> >   be ordered first by category, in canonical order as listed above, then
> >   alphabetically within a category.
> > 
> 
> That LGTM.
> 
> >>> +An example string following the order is:
> >>> +   rv64imadc_zifoo_zigoo_zafoo_sbar_scar_zxmbaz_xqux_xrux
> >>> +
> >>  
> >> IMO literal code block should be better fit for the example above,
> >> rather than definition list:
> > 
> > Uh, sure? I'm not sure what impact that has on the output, but I can
> > switch to a pre-formatted block.
> > 
> 
> Something like ``foo``?

Not posting a v2 for another few days, but this is what I currently
have:
https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git/tree/Documentation/riscv/uabi.rst?h=riscv-uabi_docs


Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)