linux-kernel - Re: [PATCH -next] selftests/ptrace: Fix Test terminated by timeout in ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212011638.31BBB562B@keescook>
Date:   Thu, 1 Dec 2022 16:48:20 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Bernd Edlinger <bernd.edlinger@...mail.de>, ebiederm@...ssion.com
Cc:     limin <limin100@...wei.com>, shuah@...nel.org,
        ebiederm@...ssion.com, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, songmuchun@...edance.com,
        lizefan.x@...edance.com
Subject: Re: [PATCH -next] selftests/ptrace: Fix Test terminated by timeout
 in ptrace_attach

On Mon, Nov 28, 2022 at 08:56:09AM +0100, Bernd Edlinger wrote:
> thanks for cleaning this up.

Oh, hm, I never saw the original email -- I'll check my Spam folder, it
gets overly excited sometimes.

> Just for completenes:
> 
> I have actually two patches submitted a while ago, but did not get any response so far,
> one that would make the test case work as it is:
> 
> [PATCH v10] exec: Fix dead-lock in de_thread with ptrace_attach
> https://lore.kernel.org/lkml/AM8PR10MB470801D01A0CF24BC32C25E7E40E9@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM/
> 
> and my favorite one, that would fix the dead-lock altogether (and adjust the test case accordingly):
> 
> [PATCH v11] exec: Fix dead-lock in de_thread with ptrace_attach
> https://lore.kernel.org/lkml/AM8PR10MB470875B22B4C08BEAEC3F77FE4169@AM8PR10MB4708.EURPRD10.PROD.OUTLOOK.COM/

This fell off my radar, but let's look at it again. Is this still an
existing race after Eric's various refactorings? I assume so. Eric, can
you looked at this case?

-- 
Kees Cook