linux-kernel - Re: [PATCH v2 05/16] KVM: x86: Remove unused argument in gpc_unmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ffc971cc6166528de7c33c30d190ece5eaee3dbf.camel@infradead.org>
Date:   Fri, 02 Dec 2022 06:21:04 -0800
From:   David Woodhouse <dwmw2@...radead.org>
To:     Michal Luczaj <mhal@...x.co>, Like Xu <like.xu.linux@...il.com>,
        Sean Christopherson <seanjc@...gle.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v2 05/16] KVM: x86: Remove unused argument in
 gpc_unmap_khva()

On Fri, 2022-12-02 at 11:57 +0100, Michal Luczaj wrote:
> On 12/2/22 10:28, Like Xu wrote:
> > On 14/10/2022 5:12 am, Sean Christopherson wrote:
> > > Remove the unused @kvm argument from gpc_unmap_khva().
> > 
> > Nit: the caller kvm_gpc_unmap() can also get rid of the unused @kvm argument.
> 
> Right, the initial series cleaned up kvm_gpc_unmap() in a separate patch.
> Current iteration removes kvm_gpc_unmap() later in the series:
> https://lore.kernel.org/kvm/20221013211234.1318131-12-seanjc@google.com/

I have been keeping that series up to date in
https://git.infradead.org/users/dwmw2/linux.git/shortlog/refs/heads/gpc-fixes

Now that the dust has settled on the Xen runstate area, I may post it
as v3 of the series.

Or I may attempt to resolve the gpc->len immutability thing first. I'm
still not really convinced Sean has won me round on that; I'm still
quite attached to the TOCTOU benefit of checking the length right there
at the moment you're going to use the pointer — especially given that
it *doesn't* have bounds checks like get_user() does, as Sean points
out.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (5965 bytes)