[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212022224.cd6atnxL-lkp@intel.com>
Date: Fri, 2 Dec 2022 22:24:18 +0800
From: kernel test robot <lkp@...el.com>
To: David Howells <dhowells@...hat.com>, rostedt@...dmis.org,
mhiramat@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
dhowells@...hat.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings
Hi David,
I love your patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v6.1-rc7 next-20221202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/David-Howells/trace-Fix-some-checker-warnings/20221202-040957
patch link: https://lore.kernel.org/r/166992525941.1716618.13740663757583361463.stgit%40warthog.procyon.org.uk
patch subject: [PATCH] trace: Fix some checker warnings
config: x86_64-randconfig-a003
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/90c2da2e191f0b26e8194f45579e8227c9950fa8
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review David-Howells/trace-Fix-some-checker-warnings/20221202-040957
git checkout 90c2da2e191f0b26e8194f45579e8227c9950fa8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> kernel/trace/trace.c:1725:13: error: use of undeclared identifier 'tracing_max_lat_fops'; did you mean 'trace_min_max_fops'?
&tracing_max_lat_fops);
^~~~~~~~~~~~~~~~~~~~
trace_min_max_fops
kernel/trace/trace.h:1994:37: note: 'trace_min_max_fops' declared here
extern const struct file_operations trace_min_max_fops;
^
1 error generated.
vim +1725 kernel/trace/trace.c
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1716)
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1717) static void trace_create_maxlat_file(struct trace_array *tr,
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1718) struct dentry *d_tracer)
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1719) {
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1720) INIT_WORK(&tr->fsnotify_work, latency_fsnotify_workfn);
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1721) init_irq_work(&tr->fsnotify_irqwork, latency_fsnotify_workfn_irq);
21ccc9cd7211628 Steven Rostedt (VMware 2021-08-18 1722) tr->d_max_latency = trace_create_file("tracing_max_latency",
21ccc9cd7211628 Steven Rostedt (VMware 2021-08-18 1723) TRACE_MODE_WRITE,
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1724) d_tracer, &tr->max_latency,
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 @1725) &tracing_max_lat_fops);
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1726) }
91edde2e6ae1dd5 Viktor Rosendahl (BMW 2019-10-09 1727)
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (153609 bytes)
Powered by blists - more mailing lists