[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46085da-4dd4-f02e-1e1d-442cfceeeb15@vosn.de>
Date: Fri, 2 Dec 2022 15:43:29 +0100 (CET)
From: Nikolaus Voss <nv@...n.de>
To: Ahmad Fatoum <a.fatoum@...gutronix.de>
cc: Nikolaus Voss <nikolaus.voss@...g-streit.com>,
Horia Geanta <horia.geanta@....com>,
Pankaj Gupta <pankaj.gupta@....com>,
Gaurav Jain <gaurav.jain@....com>,
Herbert Xu <herbert@...dor.apana.org.au>,
"David S. Miller" <davem@...emloft.net>,
David Gstir <david@...ma-star.at>,
Steffen Trumtrar <s.trumtrar@...gutronix.de>,
linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] crypto: caam: blob_gen.c: warn if key is insecure
On Fri, 2 Dec 2022, Ahmad Fatoum wrote:
> On 21.11.22 15:12, Nikolaus Voss wrote:
>> + ctrlpriv = dev_get_drvdata(jrdev->parent);
>> + moo = FIELD_GET(CSTA_MOO, ioread32(&ctrlpriv->ctrl->perfmon.status));
>
> Sorry for not having spotted this the first time, but ioread32 is not
> completely correct here as the CAAM may be big endian while the CPU is
> little endian.
>
> You should be using rd_reg32 here.
Ok.
Herbert, shall I spin v3 of the patch or patch against v2?
Niko
Powered by blists - more mailing lists