linux-kernel - Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic GL850G hub controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2f0f31551d361cf23abdd2c4117f2feb84e2b1a8.camel@icenowy.me>
Date:   Sat, 03 Dec 2022 00:54:18 +0800
From:   Icenowy Zheng <uwu@...nowy.me>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Samuel Holland <samuel@...lland.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Andre Przywara <andre.przywara@....com>
Cc:     devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCH v2 2/6] dt-bindings: usb: Add binding for Genesys Logic
 GL850G hub controller

在 2022-12-02星期五的 10:02 +0100，Krzysztof Kozlowski写道：
> On 02/12/2022 09:16, Icenowy Zheng wrote:
> > The Genesys Logic GL850G is a USB 2.0 Single TT hub controller that
> > features 4 downstream ports, an internal 5V-to-3.3V LDO regulator
> > (can
> > be bypassed) and an external reset pin.
> > 
> > Add a device tree binding for its USB protocol part. The internal
> > LDO is
> > not covered by this and can just be modelled as a fixed regulator.
> > 
> > Signed-off-by: Icenowy Zheng <uwu@...nowy.me>
> > ---
> > Changes in v2:
> > - Misc fixes suggested by Krzysztof, including property
> > descriptions,
> >   single-item "items" and fixing the example's gpio property.
> > - Fixed $id.
> > 
> (...)
> 
> > +
> > +examples:
> > +  - |
> > +    usb {
> > +        dr_mode = "host";
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        hub: hub@1 {
> > +            compatible = "usb5e3,608";
> > +            reg = <1>;
> > +            reset-gpios = <&pio 7 2>;
> 
> Use GPIO flags. What did you fix in the example?

It used to be here, but using it needs another include, which I don't
think it necessary here.

Maybe I should just drop this line in the example?

> 
> 
> 
> Best regards,
> Krzysztof
>