| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 3 Dec 2022 00:55:48 +0800
From: kernel test robot <lkp@...el.com>
To: Elliot Berman <quic_eberman@...cinc.com>,
Bjorn Andersson <quic_bjorande@...cinc.com>,
Andy Gross <agross@...nel.org>,
Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc: oe-kbuild-all@...ts.linux.dev,
Elliot Berman <quic_eberman@...cinc.com>,
Murali Nalajala <quic_mnalajal@...cinc.com>,
Trilok Soni <quic_tsoni@...cinc.com>,
Srivatsa Vaddagiri <quic_svaddagi@...cinc.com>,
Carl van Schaik <quic_cvanscha@...cinc.com>,
Prakruthi Deepak Heragu <quic_pheragu@...cinc.com>,
Arnd Bergmann <arnd@...db.de>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Jonathan Corbet <corbet@....net>,
Catalin Marinas <catalin.marinas@....com>,
Will Deacon <will@...nel.org>,
Jassi Brar <jassisinghbrar@...il.com>,
Sudeep Holla <sudeep.holla@....com>,
Mark Rutland <mark.rutland@....com>,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v7 19/20] firmware: qcom_scm: Register Gunyah platform ops
Hi Elliot,
I love your patch! Yet something to improve:
[auto build test ERROR on 094226ad94f471a9f19e8f8e7140a09c2625abaa]
url: https://github.com/intel-lab-lkp/linux/commits/Elliot-Berman/Drivers-for-gunyah-hypervisor/20221121-220942
base: 094226ad94f471a9f19e8f8e7140a09c2625abaa
patch link: https://lore.kernel.org/r/20221121140009.2353512-20-quic_eberman%40quicinc.com
patch subject: [PATCH v7 19/20] firmware: qcom_scm: Register Gunyah platform ops
config: m68k-randconfig-m041-20221201
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/e7c817504febf0e6f3171fe49429d117c4ec7bec
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Elliot-Berman/Drivers-for-gunyah-hypervisor/20221121-220942
git checkout e7c817504febf0e6f3171fe49429d117c4ec7bec
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/virt/gunyah/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All errors (new ones prefixed by >>):
>> drivers/virt/gunyah/gunyah_platform_hooks.c:39:5: error: redefinition of 'gh_rm_register_platform_ops'
39 | int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from drivers/virt/gunyah/gunyah_platform_hooks.c:8:
include/linux/gunyah_rsc_mgr.h:132:19: note: previous definition of 'gh_rm_register_platform_ops' with type 'int(struct gunyah_rm_platform_ops *)'
132 | static inline int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/virt/gunyah/gunyah_platform_hooks.c:53:6: error: redefinition of 'gh_rm_unregister_platform_ops'
53 | void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/gunyah_rsc_mgr.h:134:20: note: previous definition of 'gh_rm_unregister_platform_ops' with type 'void(struct gunyah_rm_platform_ops *)'
134 | static inline void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops) { }
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/gh_rm_register_platform_ops +39 drivers/virt/gunyah/gunyah_platform_hooks.c
732a90ac408a53 Elliot Berman 2022-11-21 38
732a90ac408a53 Elliot Berman 2022-11-21 @39 int gh_rm_register_platform_ops(struct gunyah_rm_platform_ops *platform_ops)
732a90ac408a53 Elliot Berman 2022-11-21 40 {
732a90ac408a53 Elliot Berman 2022-11-21 41 int ret = 0;
732a90ac408a53 Elliot Berman 2022-11-21 42
732a90ac408a53 Elliot Berman 2022-11-21 43 down_write(&rm_platform_ops_lock);
732a90ac408a53 Elliot Berman 2022-11-21 44 if (!rm_platform_ops)
732a90ac408a53 Elliot Berman 2022-11-21 45 rm_platform_ops = platform_ops;
732a90ac408a53 Elliot Berman 2022-11-21 46 else
732a90ac408a53 Elliot Berman 2022-11-21 47 ret = -EEXIST;
732a90ac408a53 Elliot Berman 2022-11-21 48 up_write(&rm_platform_ops_lock);
732a90ac408a53 Elliot Berman 2022-11-21 49 return ret;
732a90ac408a53 Elliot Berman 2022-11-21 50 }
732a90ac408a53 Elliot Berman 2022-11-21 51 EXPORT_SYMBOL_GPL(gh_rm_register_platform_ops);
732a90ac408a53 Elliot Berman 2022-11-21 52
732a90ac408a53 Elliot Berman 2022-11-21 @53 void gh_rm_unregister_platform_ops(struct gunyah_rm_platform_ops *platform_ops)
732a90ac408a53 Elliot Berman 2022-11-21 54 {
732a90ac408a53 Elliot Berman 2022-11-21 55 down_write(&rm_platform_ops_lock);
732a90ac408a53 Elliot Berman 2022-11-21 56 if (rm_platform_ops == platform_ops)
732a90ac408a53 Elliot Berman 2022-11-21 57 rm_platform_ops = NULL;
732a90ac408a53 Elliot Berman 2022-11-21 58 up_write(&rm_platform_ops_lock);
732a90ac408a53 Elliot Berman 2022-11-21 59 }
732a90ac408a53 Elliot Berman 2022-11-21 60 EXPORT_SYMBOL_GPL(gh_rm_unregister_platform_ops);
732a90ac408a53 Elliot Berman 2022-11-21 61
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (141101 bytes)
Powered by blists - more mailing lists