linux-kernel - Re: [PATCH] hfsplus: Add module parameter to enable force writes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <05EDE31B-9ADC-4421-B96B-98C3A8EE4C95@live.com>
Date:   Sat, 3 Dec 2022 06:22:27 +0000
From:   Aditya Garg <gargaditya08@...e.com>
To:     Andrew Morton <akpm@...ux-foundation.org>
CC:     "willy@...radead.org" <willy@...radead.org>,
        "ira.weiny@...el.com" <ira.weiny@...el.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>,
        "bvanassche@....org" <bvanassche@....org>,
        "keescook@...omium.org" <keescook@...omium.org>,
        "songmuchun@...edance.com" <songmuchun@...edance.com>,
        "slava@...eyko.com" <slava@...eyko.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] hfsplus: Add module parameter to enable force writes


> Presumably anyone who enables this knows the risk, and if it's a
> convenience, why not.
> 
> Documentation/filesystems/hfsplus.rst would be a good place to document
> this module parameter please.

I’ll add it to the v2

> All these super long lines are an eyesore.  How about
> 
> pr_warn("write access to a journaled filesystem is "
> "not supported, but has been force enabled.\n");

I’ll fix this, but you'll find a lot of eyesore lines in this driver, which I guess someone would have to fix then.