linux-kernel - Re: [PATCH V2 3/3] Input: elantech - Fix incorrectly halved touchpad range on ELAN v3 touchpads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221202234206.6527835a.nyanpasu256@gmail.com>
Date:   Fri, 2 Dec 2022 23:42:06 -0800
From:   Eirin Nya <nyanpasu256@...il.com>
To:     "phoenix" <phoenix@....com.tw>
Cc:     "'Dmitry Torokhov'" <dmitry.torokhov@...il.com>,
        <linux-input@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        "'Josh.Chen'" <josh.chen@....com.tw>
Subject: Re: [PATCH V2 3/3] Input: elantech - Fix incorrectly halved
 touchpad range on ELAN v3 touchpads

> If the setting is indeed double resolution, can we simply multiply 
> x_max and y_max by 2 instead of re-querying it?

Perhaps in some laptops, x_max or y_max is odd when resolution is
doubled, and rounded up or down in half-resolution mode, so multiplying
the half-resolution size by 2 results in a slightly incorrect full
size. I don't know if that's the case in other touchpads, but my
laptop's touchpad has even size in full-resolution (doubled) mode,
meaning it doesn't round its size in half-resolution mode (so
multiplying both values by 2 would work on my machine).

On Wed, 30 Nov 2022 19:22:25 +0800
"phoenix" <phoenix@....com.tw> wrote:

> Consulted with FW team, we suggest re-querying x/y resolution after
> setting absolute mode.

My current patch re-queries x/y resolution after setting absolute mode.
If this is the process that Elan's FW team recommends, should the patch
be kept as-is?