linux-kernel - Re: [PATCH v4 3/3] mtd: spi-nor: Add support for IS25LX256 operating in 1S-8S-8S octal read mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 3 Dec 2022 15:44:31 +0800
From:   kernel test robot <lkp@...el.com>
To:     Nathan Barrett-Morrison <nathan.morrison@...esys.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        nathan.morrison@...esys.com, greg.malysa@...esys.com,
        Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <pratyush@...nel.org>,
        Michael Walle <michael@...le.cc>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 3/3] mtd: spi-nor: Add support for IS25LX256 operating
 in 1S-8S-8S octal read mode

Hi Nathan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v6.1-rc7]
[also build test ERROR on linus/master next-20221202]
[cannot apply to mtd/spi-nor/next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Nathan-Barrett-Morrison/mtd-spi-nor-Extend-SFDP-to-support-additional-octal-modes-as-per-latest-JEDEC-standard/20221202-215808
patch link:    https://lore.kernel.org/r/20221202135539.271936-4-nathan.morrison%40timesys.com
patch subject: [PATCH v4 3/3] mtd: spi-nor: Add support for IS25LX256 operating in 1S-8S-8S octal read mode
config: x86_64-randconfig-a001
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/26787a4933a6a8591b6a66fc036e3b3c674cb57c
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Nathan-Barrett-Morrison/mtd-spi-nor-Extend-SFDP-to-support-additional-octal-modes-as-per-latest-JEDEC-standard/20221202-215808
        git checkout 26787a4933a6a8591b6a66fc036e3b3c674cb57c
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/mtd/spi-nor/issi.c:44:2: error: use of undeclared identifier 'params'; did you mean 'parameq'?
           params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
           ^~~~~~
           parameq
   include/linux/moduleparam.h:372:13: note: 'parameq' declared here
   extern bool parameq(const char *name1, const char *name2);
               ^
>> drivers/mtd/spi-nor/issi.c:44:8: error: member reference base type 'bool (const char *, const char *)' (aka '_Bool (const char *, const char *)') is not a structure or union
           params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
           ~~~~~~^ ~~~~~~
   drivers/mtd/spi-nor/issi.c:45:29: error: use of undeclared identifier 'params'
           spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_1_8],
                                      ^
   drivers/mtd/spi-nor/issi.c:49:2: error: use of undeclared identifier 'params'; did you mean 'parameq'?
           params->hwcaps.mask |= SNOR_HWCAPS_READ_1_8_8;
           ^~~~~~
           parameq
   include/linux/moduleparam.h:372:13: note: 'parameq' declared here
   extern bool parameq(const char *name1, const char *name2);
               ^
   drivers/mtd/spi-nor/issi.c:49:8: error: member reference base type 'bool (const char *, const char *)' (aka '_Bool (const char *, const char *)') is not a structure or union
           params->hwcaps.mask |= SNOR_HWCAPS_READ_1_8_8;
           ~~~~~~^ ~~~~~~
   drivers/mtd/spi-nor/issi.c:50:29: error: use of undeclared identifier 'params'
           spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_8_8],
                                      ^
   6 errors generated.


vim +44 drivers/mtd/spi-nor/issi.c

    31	
    32	static int
    33	is25lx256_post_bfpt_fixups(struct spi_nor *nor,
    34				   const struct sfdp_parameter_header *bfpt_header,
    35				   const struct sfdp_bfpt *bfpt)
    36	{
    37		/*
    38		 * IS25LX256 supports both 1S-1S-8S and 1S-8S-8S.
    39		 * However, the BFPT does not contain any information denoting this
    40		 * functionality, so the proper fast read opcodes are never setup.
    41		 * We're correcting this issue via the fixup below.  Page program
    42		 * commands are detected and setup properly via the 4BAIT lookup.
    43		 */
  > 44		params->hwcaps.mask |= SNOR_HWCAPS_READ_1_1_8;
    45		spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_1_8],
    46					  0, 8, SPINOR_OP_READ_1_1_8,
    47					  SNOR_PROTO_1_1_8);
    48	
    49		params->hwcaps.mask |= SNOR_HWCAPS_READ_1_8_8;
    50		spi_nor_set_read_settings(&params->reads[SNOR_CMD_READ_1_8_8],
    51					  0, 16, SPINOR_OP_READ_1_8_8,
    52					  SNOR_PROTO_1_8_8);
    53	
    54		return 0;
    55	}
    56	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (151645 bytes)