linux-kernel - Re: [PATCH] staging: board: Remove control flow from macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4sKulRutmI+ESrB@kadam>
Date:   Sat, 3 Dec 2022 11:37:14 +0300
From:   Dan Carpenter <error27@...il.com>
To:     Joe Peterson <jwp.linux@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: board: Remove control flow from macro

On Fri, Dec 02, 2022 at 09:05:44PM -0600, Joe Peterson wrote:
> Adhere to Linux coding style
> 
> Reported by checkpatch:
> 
> WARNING: Macros with flow control statements should be avoided
> 
> There is only one return value possible. Remove the checkpatch warning
> without effecting functionality.
> 
> Signed-off-by: Joe Peterson <jwp.linux@...il.com>
> ---

Does this break the build?

Anyway, checkpatch is wrong here.  Just ignore checkpatch if it says
silly stuff.

regards,
dan carpenter