linux-kernel - Re: [PATCH linux-next] net: record times of netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212031755.53hoTwSm-lkp@intel.com>
Date:   Sat, 3 Dec 2022 18:06:08 +0800
From:   kernel test robot <lkp@...el.com>
To:     yang.yang29@....com.cn, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, pabeni@...hat.com,
        bigeasy@...utronix.de, imagedong@...cent.com, kuniyu@...zon.com,
        petrm@...dia.com, liu3101@...due.edu, wujianguo@...natelecom.cn,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] net: record times of netdev_budget exhausted

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on next-20221202]

url:    https://github.com/intel-lab-lkp/linux/commits/yang-yang29-zte-com-cn/net-record-times-of-netdev_budget-exhausted/20221203-161326
patch link:    https://lore.kernel.org/r/202212031612057505056%40zte.com.cn
patch subject: [PATCH linux-next] net: record times of netdev_budget exhausted
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/94f9d928cabc8715256c20e909b9e730620f4ed0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review yang-yang29-zte-com-cn/net-record-times-of-netdev_budget-exhausted/20221203-161326
        git checkout 94f9d928cabc8715256c20e909b9e730620f4ed0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/core/net-procfs.c: In function 'softnet_seq_show':
   net/core/net-procfs.c:177:60: error: expected ')' before 'sd'
     177 |                    softnet_backlog_len(sd), (int)seq->index
         |                                                            ^
         |                                                            )
     178 |                    sd->budget_exhaust);
         |                    ~~                                       
   net/core/net-procfs.c:171:19: note: to match this '('
     171 |         seq_printf(seq,
         |                   ^
>> net/core/net-procfs.c:172:89: warning: format '%x' expects a matching 'unsigned int' argument [-Wformat=]
     172 |                    "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
         |                                                                                      ~~~^
         |                                                                                         |
         |                                                                                         unsigned int


vim +172 net/core/net-procfs.c

   166	
   167		/* the index is the CPU id owing this sd. Since offline CPUs are not
   168		 * displayed, it would be othrwise not trivial for the user-space
   169		 * mapping the data a specific CPU
   170		 */
   171		seq_printf(seq,
 > 172			   "%08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x %08x\n",
   173			   sd->processed, sd->dropped, sd->time_squeeze, 0,
   174			   0, 0, 0, 0, /* was fastroute */
   175			   0,	/* was cpu_collision */
   176			   sd->received_rps, flow_limit_count,
   177			   softnet_backlog_len(sd), (int)seq->index
   178			   sd->budget_exhaust);
   179		return 0;
   180	}
   181	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (284550 bytes)