[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4tuOyKOdZcQ4sjm@smile.fi.intel.com>
Date: Sat, 3 Dec 2022 17:41:47 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Yinbo Zhu <zhuyinbo@...ngson.cn>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <brgl@...ev.pl>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
WANG Xuerui <kernel@...0n.name>,
Jiaxun Yang <jiaxun.yang@...goat.com>,
Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
Juxin Gao <gaojuxin@...ngson.cn>,
Bibo Mao <maobibo@...ngson.cn>,
Yanteng Si <siyanteng@...ngson.cn>, linux-gpio@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
loongarch@...ts.linux.dev, linux-mips@...r.kernel.org,
Arnaud Patard <apatard@...driva.com>,
Huacai Chen <chenhuacai@...nel.org>,
Jianmin Lv <lvjianmin@...ngson.cn>,
Hongchen Zhang <zhanghongchen@...ngson.cn>,
Liu Peibao <liupeibao@...ngson.cn>
Subject: Re: [PATCH v10 1/2] gpio: loongson: add gpio driver support
On Sat, Dec 03, 2022 at 05:27:31PM +0200, Andy Shevchenko wrote:
> On Sat, Dec 03, 2022 at 06:53:20PM +0800, Yinbo Zhu wrote:
> > 在 2022/12/3 18:03, Linus Walleij 写道:
> > > On Thu, Dec 1, 2022 at 1:33 PM Yinbo Zhu <zhuyinbo@...ngson.cn> wrote:
> > > > +config GPIO_LOONGSON_64BIT
> > > > + tristate "Loongson 64 bit GPIO support"
> > > > + depends on LOONGARCH || COMPILE_TEST
> > > > + select GPIO_GENERIC
> > > > + select GPIOLIB_IRQCHIP
> > > If the kernelbots start complaining you might need to add a:
> > >
> > > select IRQ_DOMAIN_HIERARCHY
> > >
> > > here.
> >
> > Bartosz had merged my patch and I will add a change on top of the existing
> > series.
>
> I don;'t know why he had done that, the driver requires a lot of cleanups,
> e.g. why it uses acpi.h, what that "nice" container of the platform device for.
+ we have macros for get_direction() returned values and so on.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists