linux-kernel - Re: [PATCH v6 04/11] cpufreq: amd_pstate: implement Pstate EPP support for the AMD processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Dec 2022 03:52:35 +0800
From:   kernel test robot <lkp@...el.com>
To:     Perry Yuan <perry.yuan@....com>, rafael.j.wysocki@...el.com,
        Mario.Limonciello@....com, ray.huang@....com,
        viresh.kumar@...aro.org
Cc:     oe-kbuild-all@...ts.linux.dev, Deepak.Sharma@....com,
        Nathan.Fontenot@....com, Alexander.Deucher@....com,
        Shimmer.Huang@....com, Xiaojian.Du@....com, Li.Meng@....com,
        wyes.karny@....com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 04/11] cpufreq: amd_pstate: implement Pstate EPP
 support for the AMD processors

Hi Perry,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v6.1-rc7 next-20221202]
[cannot apply to tip/x86/core]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Perry-Yuan/Implement-AMD-Pstate-EPP-Driver/20221202-155515
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20221202074719.623673-5-perry.yuan%40amd.com
patch subject: [PATCH v6 04/11] cpufreq: amd_pstate: implement Pstate EPP support for the AMD processors
config: i386-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/6f2da26e9fe72400ed922b14ea494beb5e38dc59
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Perry-Yuan/Implement-AMD-Pstate-EPP-Driver/20221202-155515
        git checkout 6f2da26e9fe72400ed922b14ea494beb5e38dc59
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/cpufreq/amd-pstate.c: In function 'amd_pstate_get_energy_pref_index':
>> drivers/cpufreq/amd-pstate.c:111:15: error: implicit declaration of function 'amd_pstate_get_epp' [-Werror=implicit-function-declaration]
     111 |         epp = amd_pstate_get_epp(cpudata, 0);
         |               ^~~~~~~~~~~~~~~~~~
   drivers/cpufreq/amd-pstate.c: In function 'store_energy_performance_preference':
>> drivers/cpufreq/amd-pstate.c:758:15: error: implicit declaration of function 'amd_pstate_set_energy_pref_index'; did you mean 'amd_pstate_get_energy_pref_index'? [-Werror=implicit-function-declaration]
     758 |         ret = amd_pstate_set_energy_pref_index(cpudata, ret);
         |               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |               amd_pstate_get_energy_pref_index
   drivers/cpufreq/amd-pstate.c: In function 'update_boost_state':
   drivers/cpufreq/amd-pstate.c:803:29: warning: variable 'cpudata' set but not used [-Wunused-but-set-variable]
     803 |         struct amd_cpudata *cpudata;
         |                             ^~~~~~~
   In file included from drivers/cpufreq/amd-pstate.c:40:
   At top level:
   include/linux/cpufreq_common.h:48:21: warning: 'epp_values' defined but not used [-Wunused-variable]
      48 | static unsigned int epp_values[] = {
         |                     ^~~~~~~~~~
   cc1: some warnings being treated as errors


vim +/amd_pstate_get_epp +111 drivers/cpufreq/amd-pstate.c

   105	
   106	static int amd_pstate_get_energy_pref_index(struct amd_cpudata *cpudata)
   107	{
   108		s16 epp;
   109		int index = -EINVAL;
   110	
 > 111		epp = amd_pstate_get_epp(cpudata, 0);
   112		if (epp < 0)
   113			return epp;
   114	
   115		switch (epp) {
   116		case HWP_EPP_PERFORMANCE:
   117			index = EPP_INDEX_PERFORMANCE;
   118			break;
   119		case HWP_EPP_BALANCE_PERFORMANCE:
   120			index = EPP_INDEX_BALANCE_PERFORMANCE;
   121			break;
   122		case HWP_EPP_BALANCE_POWERSAVE:
   123			index = EPP_INDEX_BALANCE_POWERSAVE;
   124			break;
   125		case HWP_EPP_POWERSAVE:
   126			index = EPP_INDEX_POWERSAVE;
   127			break;
   128		default:
   129				break;
   130		}
   131	
   132		return index;
   133	}
   134	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (288264 bytes)