linux-kernel - Re: [PATCH] power: supply: Fix refcount leak in rk817_charger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221203012322.pfempb5m4qtj6mjm@mercury.elektranox.org>
Date:   Sat, 3 Dec 2022 02:23:22 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Chris Morgan <macroalpha82@...il.com>
Cc:     Qiheng Lin <linqiheng@...wei.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] power: supply: Fix refcount leak in rk817_charger_probe

Hi,

On Tue, Nov 29, 2022 at 11:35:45AM -0600, Chris Morgan wrote:
> On Mon, Nov 28, 2022 at 10:27:40PM +0800, Qiheng Lin wrote:
> > of_get_child_by_name() returns a node pointer with refcount
> > incremented, we should use of_node_put() on it when not need anymore.
> > Add missing of_node_put() to avoid refcount leak.
> > 
> > Fixes: 11cb8da0189b ("power: supply: Add charger driver for Rockchip RK817")
> > Signed-off-by: Qiheng Lin <linqiheng@...wei.com>
> 
> Good catch, thank you!
> 
> Reviewed-by: Chris Morgan <macromorgan@...mail.com>

Thanks, merged.

-- Sebastian

> > ---
> >  drivers/power/supply/rk817_charger.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/supply/rk817_charger.c b/drivers/power/supply/rk817_charger.c
> > index 635f051b0821..d25a81d79fac 100644
> > --- a/drivers/power/supply/rk817_charger.c
> > +++ b/drivers/power/supply/rk817_charger.c
> > @@ -1060,8 +1060,10 @@ static int rk817_charger_probe(struct platform_device *pdev)
> >  		return -ENODEV;
> > 
> >  	charger = devm_kzalloc(&pdev->dev, sizeof(*charger), GFP_KERNEL);
> > -	if (!charger)
> > +	if (!charger) {
> > +		of_node_put(node);
> >  		return -ENOMEM;
> > +	}
> > 
> >  	charger->rk808 = rk808;
> > 
> > --
> > 2.32.0
> > 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)