linux-kernel - Re: [PATCH] iommu/vt-d: Fix buggy QAT device mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 2 Dec 2022 17:41:19 -0800
From:   Ashok Raj <ashok.raj@...el.com>
To:     Jacob Pan <jacob.jun.pan@...ux.intel.com>
CC:     <iommu@...ts.linux.dev>, LKML <linux-kernel@...r.kernel.org>,
        Lu Baolu <baolu.lu@...ux.intel.com>,
        Joerg Roedel <joro@...tes.org>,
        David Woodhouse <dwmw2@...radead.org>,
        Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>, Yi Liu <yi.l.liu@...el.com>,
        "Tian, Kevin" <kevin.tian@...el.com>,
        Raghunathan Srinivasan <raghunathan.srinivasan@...el.com>,
        Ashok Raj <ashok.raj@...el.com>
Subject: Re: [PATCH] iommu/vt-d: Fix buggy QAT device mask

On Fri, Dec 02, 2022 at 04:56:10PM -0800, Jacob Pan wrote:
> Impacted QAT device IDs that need extra dtlb flush quirk is ranging
> from 0x4940 to 0x4943. After bitwise AND device ID with 0xfffc the
> result should be 0x4940 instead of 0x494c to identify these devices.

Can you add the lore link for the original post here just for reference.

as a Link: tag, since this depends on the other patch.

> 
> Reported-by: Raghunathan Srinivasan <raghunathan.srinivasan@...el.com>
> Signed-off-by: Jacob Pan <jacob.jun.pan@...ux.intel.com>

Signed-off-by: Ashok Raj <ashok.raj@...el.com>
> ---
>  drivers/iommu/intel/iommu.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/intel/iommu.c b/drivers/iommu/intel/iommu.c
> index d8759f445aff..0b10104c4b99 100644
> --- a/drivers/iommu/intel/iommu.c
> +++ b/drivers/iommu/intel/iommu.c
> @@ -1401,7 +1401,7 @@ static void domain_update_iotlb(struct dmar_domain *domain)
>   * This quirk is exempted from risky_device() check because it applies only
>   * to the built-in QAT devices and it doesn't grant additional privileges.
>   */
> -#define BUGGY_QAT_DEVID_MASK 0x494c
> +#define BUGGY_QAT_DEVID_MASK 0x4940
>  static bool dev_needs_extra_dtlb_flush(struct pci_dev *pdev)
>  {
>  	if (pdev->vendor != PCI_VENDOR_ID_INTEL)
> -- 
> 2.25.1
>