linux-kernel - Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in pcpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6a732c63-125e-c033-3869-87dea6c53e8f@gentwo.de>
Date:   Sun, 4 Dec 2022 17:21:44 +0100 (CET)
From:   Christoph Lameter <cl@...two.de>
To:     Baoquan He <bhe@...hat.com>
cc:     Wupeng Ma <mawupeng1@...wei.com>, akpm@...ux-foundation.org,
        tj@...nel.org, dennis@...nel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next 1/1] percpu: cleanup invalid assignment to err in
 pcpu_alloc

On Sun, 4 Dec 2022, Baoquan He wrote:

> Can we change the conditional checking in fail part as below?

Yes please. This is potentially a rare condition that should get some
visibility.