[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y4zXpWEo5rJdNecG@lunn.ch>
Date: Sun, 4 Dec 2022 18:23:49 +0100
From: Andrew Lunn <andrew@...n.ch>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Piergiorgio Beruto <piergiorgio.beruto@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, linux-kernel@...r.kernel.org,
netdev@...r.kernel.org, Oleksij Rempel <o.rempel@...gutronix.de>
Subject: Re: [PATCH net-next 3/4] drivers/net/phy: Add driver for the onsemi
NCN26000 10BASE-T1S PHY
> > +
> > + // bring up the link (link_ctrl is mapped to BMCR_ANENABLE)
> > + // clear also ISOLATE mode and Collision Test
> > + return phy_write(phydev, MII_BMCR, BMCR_ANENABLE);
>
> You always use AN even when ethtool turns off AN? If AN is mandatory,
> it seems there should be some way that phylib can force that to be
> the case.
Hi Russell
The comment is trying to explain that the bit BMCR_ANENABLE does not
actually mean Enable Autoneg. Since AN is not supported by T1S PHYs,
and the standard, some vendors have repurposed this bit.
Maybe we need BMCR_T1S_LINK_CTRL, local to this driver.
Andrew
Powered by blists - more mailing lists