linux-kernel - Re: [PATCH v6 5/5] drivers: Implement module modaliases for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Dec 2022 09:27:04 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Christophe Leroy <christophe.leroy@...roup.eu>
Cc:     Allen Webb <allenwebb@...gle.com>,
        "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v6 5/5] drivers: Implement module modaliases for USB

On Sat, Dec 03, 2022 at 06:25:46PM +0000, Christophe Leroy wrote:
> > +
> > +#ifdef CONFIG_USB
> > +/* USB related modaliases can be split because of device number matching, so
> > + * this function handles individual modaliases for one segment of the range.
> > + */
> > +static ssize_t usb_id_to_modalias(const struct usb_device_id *id,
> > +				  unsigned int bcdDevice_initial,
> 
> No camelCase please.
> 
> See https://docs.kernel.org/process/coding-style.html#naming

This is a name that comes directly from the USB specification, and as
such, those usages of CamelCase are allowed as they refer to well-known
fields.

But, the field is called bcdDevice, not bcdDevice_initial, so this could
get a better name overall as it doesn't directly match up, so it should
be changed to something a bit nicer.

thanks,

greg k-h