| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20221205194934.GA2476927-robh@kernel.org>
Date: Mon, 5 Dec 2022 13:49:34 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konrad.dybcio@...aro.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Manivannan Sadhasivam <mani@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 08/15] dt-bindings: remoteproc: qcom,sm8150-pas: split
into separate file
On Thu, Nov 24, 2022 at 07:43:26PM +0100, Krzysztof Kozlowski wrote:
> Split SM8150 and SM8250 remote processor Peripheral Authentication
> Service bindings into their own file to reduce complexity and make
> maintenance easier.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Changes since v2:
> 1. Drop if:then: for the clock and put it directly under properties.
> 2. Merge two if:then: clauses for setting interrupts.
>
> Changes since v1:
> 1. Add qcom,qmp (not part of qcom,pas-common.yaml# anymore).
> 2. Add firmware-name to example.
> ---
> .../bindings/remoteproc/qcom,adsp.yaml | 27 ---
> .../bindings/remoteproc/qcom,sm8150-pas.yaml | 166 ++++++++++++++++++
> 2 files changed, 166 insertions(+), 27 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
>
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> index 67941e79a4a0..e8d66eefd522 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml
> @@ -40,13 +40,6 @@ properties:
> - qcom,sm6350-adsp-pas
> - qcom,sm6350-cdsp-pas
> - qcom,sm6350-mpss-pas
> - - qcom,sm8150-adsp-pas
> - - qcom,sm8150-cdsp-pas
> - - qcom,sm8150-mpss-pas
> - - qcom,sm8150-slpi-pas
> - - qcom,sm8250-adsp-pas
> - - qcom,sm8250-cdsp-pas
> - - qcom,sm8250-slpi-pas
>
> reg:
> maxItems: 1
> @@ -94,13 +87,6 @@ allOf:
> - qcom,sm6350-adsp-pas
> - qcom,sm6350-cdsp-pas
> - qcom,sm6350-mpss-pas
> - - qcom,sm8150-adsp-pas
> - - qcom,sm8150-cdsp-pas
> - - qcom,sm8150-mpss-pas
> - - qcom,sm8150-slpi-pas
> - - qcom,sm8250-adsp-pas
> - - qcom,sm8250-cdsp-pas
> - - qcom,sm8250-slpi-pas
> then:
> properties:
> clocks:
> @@ -150,12 +136,6 @@ allOf:
> - qcom,sdm845-cdsp-pas
> - qcom,sm6350-adsp-pas
> - qcom,sm6350-cdsp-pas
> - - qcom,sm8150-adsp-pas
> - - qcom,sm8150-cdsp-pas
> - - qcom,sm8150-slpi-pas
> - - qcom,sm8250-adsp-pas
> - - qcom,sm8250-cdsp-pas
> - - qcom,sm8250-slpi-pas
> then:
> properties:
> interrupts:
> @@ -173,7 +153,6 @@ allOf:
> - qcom,sc8180x-mpss-pas
> - qcom,sdx55-mpss-pas
> - qcom,sm6350-mpss-pas
> - - qcom,sm8150-mpss-pas
> then:
> properties:
> interrupts:
> @@ -199,8 +178,6 @@ allOf:
> - qcom,msm8226-adsp-pil
> - qcom,msm8996-adsp-pil
> - qcom,msm8998-adsp-pas
> - - qcom,sm8150-adsp-pas
> - - qcom,sm8150-cdsp-pas
> then:
> properties:
> power-domains:
> @@ -272,7 +249,6 @@ allOf:
> - qcom,sc7280-mpss-pas
> - qcom,sdx55-mpss-pas
> - qcom,sm6350-mpss-pas
> - - qcom,sm8150-mpss-pas
> then:
> properties:
> power-domains:
> @@ -293,9 +269,6 @@ allOf:
> - qcom,sc8180x-cdsp-pas
> - qcom,sc8280xp-adsp-pas
> - qcom,sm6350-adsp-pas
> - - qcom,sm8150-slpi-pas
> - - qcom,sm8250-adsp-pas
> - - qcom,sm8250-slpi-pas
> then:
> properties:
> power-domains:
> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> new file mode 100644
> index 000000000000..b934252cf02b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml
> @@ -0,0 +1,166 @@
> +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/remoteproc/qcom,sm8150-pas.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SM8150/SM8250 Peripheral Authentication Service
> +
> +maintainers:
> + - Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> +
> +description:
> + Qualcomm SM8150/SM8250 SoC Peripheral Authentication Service loads and boots
> + firmware on the Qualcomm DSP Hexagon cores.
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sm8150-adsp-pas
> + - qcom,sm8150-cdsp-pas
> + - qcom,sm8150-mpss-pas
> + - qcom,sm8150-slpi-pas
> + - qcom,sm8250-adsp-pas
> + - qcom,sm8250-cdsp-pas
> + - qcom,sm8250-slpi-pas
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: XO clock
> +
> + clock-names:
> + items:
> + - const: xo
> +
> + qcom,qmp:
> + $ref: /schemas/types.yaml#/definitions/phandle
> + description: Reference to the AOSS side-channel message RAM.
Not ideal that we are defining the type here multiple times.
Otherwise,
Acked-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists