linux-kernel - Re: [PATCH v4 14/23] scsi: ufs: ufs-qcom: Remove un-necessary WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 11:55:04 -0800
From:   Asutosh Das <quic_asutoshd@...cinc.com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
CC:     <martin.petersen@...cle.com>, <jejb@...ux.ibm.com>,
        <andersson@...nel.org>, <vkoul@...nel.org>,
        <quic_cang@...cinc.com>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-phy@...ts.infradead.org>,
        <linux-scsi@...r.kernel.org>, <dmitry.baryshkov@...aro.org>,
        <ahalaney@...hat.com>, <abel.vesa@...aro.org>,
        <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <bvanassche@....org>
Subject: Re: [PATCH v4 14/23] scsi: ufs: ufs-qcom: Remove un-necessary
 WARN_ON()

On Thu, Dec 01 2022 at 09:45 -0800, Manivannan Sadhasivam wrote:
>In the reset assert and deassert callbacks, the supplied "id" is not used
>at all and only the hba reset is performed all the time. So there is no
>reason to use a WARN_ON on the "id".
>
>Reviewed-by: Andrew Halaney <ahalaney@...hat.com>
>Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>---
> drivers/ufs/host/ufs-qcom.c | 4 ----
> 1 file changed, 4 deletions(-)
>
LGTM.

Reviewed-by: Asutosh Das <quic_asutoshd@...cinc.com>

>diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c
>index 7cd996ac180b..8bb0f4415f1a 100644
>--- a/drivers/ufs/host/ufs-qcom.c
>+++ b/drivers/ufs/host/ufs-qcom.c
>@@ -895,8 +895,6 @@ ufs_qcom_reset_assert(struct reset_controller_dev *rcdev, unsigned long id)
> {
> 	struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);
>
>-	/* Currently this code only knows about a single reset. */
>-	WARN_ON(id);
> 	ufs_qcom_assert_reset(host->hba);
> 	/* provide 1ms delay to let the reset pulse propagate. */
> 	usleep_range(1000, 1100);
>@@ -908,8 +906,6 @@ ufs_qcom_reset_deassert(struct reset_controller_dev *rcdev, unsigned long id)
> {
> 	struct ufs_qcom_host *host = rcdev_to_ufs_host(rcdev);
>
>-	/* Currently this code only knows about a single reset. */
>-	WARN_ON(id);
> 	ufs_qcom_deassert_reset(host->hba);
>
> 	/*
>-- 
>2.25.1
>