linux-kernel - Re: [PATCH v4 08/18] dt-bindings: msm: dsi-controller-main: Add vdd* descriptions back in

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 14:01:31 -0600
From:   Rob Herring <robh@...nel.org>
To:     Bryan O'Donoghue <bryan.odonoghue@...aro.org>
Cc:     devicetree@...r.kernel.org, robh+dt@...nel.org,
        quic_abhinavk@...cinc.com, dmitry.baryshkov@...aro.org,
        agross@...nel.org, robdclark@...il.com, daniel@...ll.ch,
        linux-arm-msm@...r.kernel.org, krzysztof.kozlowski+dt@...aro.org,
        david@...t.cz, airlied@...il.com, freedreno@...ts.freedesktop.org,
        sean@...rly.run, swboyd@...omium.org,
        dri-devel@...ts.freedesktop.org, andersson@...nel.org,
        dianders@...omium.org, konrad.dybcio@...ainline.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 08/18] dt-bindings: msm: dsi-controller-main: Add vdd*
 descriptions back in


On Fri, 25 Nov 2022 12:36:28 +0000, Bryan O'Donoghue wrote:
> When converting from .txt to .yaml we didn't include descriptions for the
> existing regulator supplies.
> 
> - vdd
> - vdda
> - vddio
> 
> Add those descriptions into the yaml now as they were prior to the
> conversion. In the .txt description we marked these regulators as required,
> however, that requirement appears to have been in error.
> 
> Taking the example of sc7180-trogdor-wormdingler.dtsi. The avdd and avee
> come from GPIO controlled external regulators, not the SoC and in this case
> there's no need for vddio to power an I/O bus. Similarly the regulators for
> the LCD are controlled by the panel driver not by the dsi-ctrl driver.
> 
> It would be possible to connect a different type of panel to the DSI bus
> here in which case we may or may not want to make use of vdd, vdda or
> vddio.
> 
> This is also the case for older chipsets like apq8064, msm8916 etc the vdd*
> regulators in the dsi-ctrl block are helpers not dependencies.
> 
> Add the description of vdd, vdda and vddio back in for the existing
> upstream dts where vdd, vdda or vddio are already declared but, don't
> declare those regulators required - they are not SoC requirements.
> 
> Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings")
> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> ---
>  .../bindings/display/msm/dsi-controller-main.yaml    | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 

Acked-by: Rob Herring <robh@...nel.org>