linux-kernel - Re: [PATCH v4 net-next 5/9] dt-bindings: net: dsa: qca8k: utilize shared dsa.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <167027655461.2675313.2465931055798706710.robh@kernel.org>
Date:   Mon, 5 Dec 2022 15:42:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Colin Foster <colin.foster@...advantage.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Jakub Kicinski <kuba@...nel.org>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Clément Léger <clement.leger@...tlin.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-mediatek@...ts.infradead.org,
        George McCollister <george.mccollister@...il.com>,
        Sean Wang <sean.wang@...iatek.com>,
        Landen Chao <Landen.Chao@...iatek.com>,
        linux-arm-kernel@...ts.infradead.org,
        John Crispin <john@...ozen.org>, UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>,
        Woojung Huh <woojung.huh@...rochip.com>,
        netdev@...r.kernel.org, Kurt Kanzenbach <kurt@...utronix.de>,
        Florian Fainelli <f.fainelli@...il.com>,
        ,nç ÜNAL <arinc.unal@...nc9.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        linux-renesas-soc@...r.kernel.org, Marek Vasut <marex@...x.de>,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        DENG Qingfang <dqfext@...il.com>,
        Paolo Abeni <pabeni@...hat.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH v4 net-next 5/9] dt-bindings: net: dsa: qca8k: utilize
 shared dsa.yaml


On Fri, 02 Dec 2022 12:45:55 -0800, Colin Foster wrote:
> The dsa.yaml binding contains duplicated bindings for address and size
> cells, as well as the reference to dsa-port.yaml. Instead of duplicating
> this information, remove the reference to dsa-port.yaml and include the
> full reference to dsa.yaml.
> 
> Signed-off-by: Colin Foster <colin.foster@...advantage.com>
> Suggested-by: Vladimir Oltean <olteanv@...il.com>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> 
> v3 -> v4
>   * Add Reviewed tag
>   * Remove unnecessary blank line deletion
> 
> v2 -> v3
>   * Remove #address-cells and #size-cells from v2. The examples were
>     incorrect and fixed elsewhere.
>   * Remove erroneous unevaluatedProperties: true under Ethernet Port.
>   * Add back ref: dsa-port.yaml#.
> 
> v1 -> v2
>   * Add #address-cells and #size-cells to the switch layer. They aren't
>     part of dsa.yaml.
>   * Add unevaluatedProperties: true to the ethernet-port layer so it can
>     correctly read properties from dsa.yaml.
> 
> ---
>  Documentation/devicetree/bindings/net/dsa/qca8k.yaml | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
> 

Reviewed-by: Rob Herring <robh@...nel.org>