linux-kernel - Re: [PATCH linux-next] soc: qcom: smem_state: Use device_match_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221205220100.a2omqdmhtw26i7qx@builder.lan>
Date:   Mon, 5 Dec 2022 16:01:00 -0600
From:   Bjorn Andersson <andersson@...nel.org>
To:     ye.xingchen@....com.cn
Cc:     agross@...nel.org, konrad.dybcio@...aro.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next] soc: qcom: smem_state: Use
 device_match_of_node()

On Thu, Nov 17, 2022 at 03:48:06PM +0800, ye.xingchen@....com.cn wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
> 
> Replace the open-code with device_match_of_node().
> 
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
>  drivers/soc/qcom/smem_state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/smem_state.c b/drivers/soc/qcom/smem_state.c
> index e848cc9a3cf8..a7844841a727 100644
> --- a/drivers/soc/qcom/smem_state.c
> +++ b/drivers/soc/qcom/smem_state.c
> @@ -63,7 +63,7 @@ static struct qcom_smem_state *of_node_to_state(struct device_node *np)
>  	mutex_lock(&list_lock);
> 
>  	list_for_each_entry(state, &smem_states, list) {
> -		if (state->of_node == np) {
> +		if (device_match_of_node(state, np)) {

I don't find this form easier to read, nor is state a struct device *...

Regards,
Bjorn

>  			kref_get(&state->refcount);
>  			goto unlock;
>  		}
> -- 
> 2.25.1