linux-kernel - Re: [PATCH 11/11] dmapool: link blocks across pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 6 Dec 2022 06:34:51 +0800
From:   kernel test robot <lkp@...el.com>
To:     Keith Busch <kbusch@...a.com>, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Matthew Wilcox <willy@...radead.org>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Tony Battersby <tonyb@...ernetics.com>,
        Keith Busch <kbusch@...nel.org>
Subject: Re: [PATCH 11/11] dmapool: link blocks across pages

Hi Keith,

I love your patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.1-rc8]
[cannot apply to next-20221205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/dmapool-enhancements/20221205-232116
patch link:    https://lore.kernel.org/r/20221205145937.54367-12-kbusch%40meta.com
patch subject: [PATCH 11/11] dmapool: link blocks across pages
config: x86_64-randconfig-a006-20221205
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/3717500cb5479136121a65d22d48f4b5e940bba4
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Keith-Busch/dmapool-enhancements/20221205-232116
        git checkout 3717500cb5479136121a65d22d48f4b5e940bba4
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> mm/dmapool.c:306:6: error: incompatible pointer types initializing 'u8 *' (aka 'unsigned char *') with an expression of type 'struct dma_block *' [-Werror,-Wincompatible-pointer-types]
           u8 *data = block;
               ^      ~~~~~
   1 error generated.


vim +306 mm/dmapool.c

   301	
   302	static inline void pool_check_block(struct dma_pool *pool, struct dma_block *block,
   303					    gfp_t mem_flags)
   304	{
   305	#ifdef DMAPOOL_DEBUG
 > 306		u8 *data = block;
   307		int i;
   308	
   309		for (i = sizeof(struct dma_block); i < pool->size; i++) {
   310			if (data[i] == POOL_POISON_FREED)
   311				continue;
   312			dev_err(pool->dev, "%s %s, %p (corrupted)\n", __func__,
   313				pool->name, block);
   314	
   315			/*
   316			 * Dump the first 4 bytes even if they are not
   317			 * POOL_POISON_FREED
   318			 */
   319			print_hex_dump(KERN_ERR, "", DUMP_PREFIX_OFFSET, 16, 1,
   320					data, pool->size, 1);
   321			break;
   322		}
   323	
   324		if (!want_init_on_alloc(mem_flags))
   325			memset(block, POOL_POISON_ALLOCATED, pool->size);
   326	#endif
   327	}
   328	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (121371 bytes)