linux-kernel - arch/mips/boot/compressed/dbg.c:12:13: warning: no previous prototype for 'putc'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202212051458.5aEo4Efn-lkp@intel.com>
Date:   Mon, 5 Dec 2022 14:51:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     YunQiang Su <yunqiang.su@...united.com>
Cc:     oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: arch/mips/boot/compressed/dbg.c:12:13: warning: no previous
 prototype for 'putc'

Hi YunQiang,

First bad commit (maybe != root cause):

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   76dcd734eca23168cb008912c0f69ff408905235
commit: 31b2f3dc851c65fee288612432c4fc956f1a264e MIPS: enable both vmlinux.gz.itb and vmlinuz for generic
date:   11 months ago
config: mips-allmodconfig
compiler: mips-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=31b2f3dc851c65fee288612432c4fc956f1a264e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 31b2f3dc851c65fee288612432c4fc956f1a264e
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=mips SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

Note: functions only called from assembly code should be annotated with the asmlinkage attribute
All warnings (new ones prefixed by >>):

>> arch/mips/boot/compressed/dbg.c:12:13: warning: no previous prototype for 'putc' [-Wmissing-prototypes]
      12 | void __weak putc(char c)
         |             ^~~~
>> arch/mips/boot/compressed/dbg.c:16:6: warning: no previous prototype for 'puts' [-Wmissing-prototypes]
      16 | void puts(const char *s)
         |      ^~~~
>> arch/mips/boot/compressed/dbg.c:26:6: warning: no previous prototype for 'puthex' [-Wmissing-prototypes]
      26 | void puthex(unsigned long long val)
         |      ^~~~~~


vim +/putc +12 arch/mips/boot/compressed/dbg.c

1b93b3c3e94be2 Wu Zhangjin 2009-10-14  11  
e52dd9fc6b9e0c Wu Zhangjin 2010-01-26 @12  void __weak putc(char c)
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  13  {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  14  }
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  15  
1b93b3c3e94be2 Wu Zhangjin 2009-10-14 @16  void puts(const char *s)
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  17  {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  18  	char c;
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  19  	while ((c = *s++) != '\0') {
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  20  		putc(c);
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  21  		if (c == '\n')
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  22  			putc('\r');
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  23  	}
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  24  }
1b93b3c3e94be2 Wu Zhangjin 2009-10-14  25  
1b93b3c3e94be2 Wu Zhangjin 2009-10-14 @26  void puthex(unsigned long long val)

:::::: The code at line 12 was first introduced by commit
:::::: e52dd9fc6b9e0c17b220bd38371ff15032a1a155 MIPS: Simplify the weak annotation with __weak

:::::: TO: Wu Zhangjin <wuzhangjin@...il.com>
:::::: CC: Ralf Baechle <ralf@...ux-mips.org>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (302502 bytes)