linux-kernel - Re: [PATCH] ARM: dts: qcom: apq8084-ifc6540: fix overriding SDHCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 08:43:13 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Bhupesh Sharma <bhupesh.sharma@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: qcom: apq8084-ifc6540: fix overriding SDHCI

On 04/12/2022 12:11, Dmitry Baryshkov wrote:
> On Sun, 4 Dec 2022 at 10:46, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> While changing node names of APQ8084 SDHCI, the ones in IFC6540 board
>> were not updated leading to disabled and misconfigured SDHCI.
>>
>> Cc: <stable@...r.kernel.org>
>> Fixes: 2477d81901a2 ("ARM: dts: qcom: Fix sdhci node names - use 'mmc@'")
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> 
> Minor nit below.
> 
>> ---
>>  arch/arm/boot/dts/qcom-apq8084-ifc6540.dts | 20 ++++++++++----------
>>  arch/arm/boot/dts/qcom-apq8084.dtsi        |  4 ++--
>>  2 files changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> index 44cd72f1b1be..116e59a3b76d 100644
>> --- a/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> +++ b/arch/arm/boot/dts/qcom-apq8084-ifc6540.dts
>> @@ -19,16 +19,16 @@ soc {
>>                 serial@...5e000 {
>>                         status = "okay";
>>                 };
>> +       };
>> +};
>>
>> -               sdhci@...24900 {
>> -                       bus-width = <8>;
>> -                       non-removable;
>> -                       status = "okay";
>> -               };
>> +&sdhc_1 {
>> +       bus-width = <8>;
>> +       non-removable;
>> +       status = "okay";
>> +};
>>
>> -               sdhci@...a4900 {
>> -                       cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>> -                       bus-width = <4>;
>> -               };
>> -       };
>> +&sdhc_2 {
>> +       cd-gpios = <&tlmm 122 GPIO_ACTIVE_LOW>;
>> +       bus-width = <4>;
> 
> Technically this will still be disabled, as there is no 'status = "okay";' here.
> 

Yes, but I think this is separate issue, not related to node renaming.
The initial patch which added these said:
"required for enabling the serial port and eMMC."
so I assume SD card controller was meant to stay disabled.

Best regards,
Krzysztof