linux-kernel - Re: [PATCH net-next] net/mlx5: remove redundant ret variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7eea41f2-ef05-ab5d-0191-d155ccdfb5e0@nvidia.com>
Date:   Mon, 5 Dec 2022 10:10:28 +0200
From:   Roi Dayan <roid@...dia.com>
To:     zhang.songyi@....com.cn, leon@...nel.org
Cc:     saeedm@...dia.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, kliteyn@...dia.com,
        shunh@...dia.com, rongweil@...dia.com, valex@...dia.com,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net/mlx5: remove redundant ret variable



On 05/12/2022 8:24, zhang.songyi@....com.cn wrote:
> From: zhang songyi <zhang.songyi@....com.cn>
> 
> Return value from mlx5dr_send_postsend_action() directly instead of taking
> this in another redundant variable.
> 
> Signed-off-by: zhang songyi <zhang.songyi@....com.cn>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> index a4476cb4c3b3..fd2d31cdbcf9 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/dr_send.c
> @@ -724,7 +724,6 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
>  				struct mlx5dr_action *action)
>  {
>  	struct postsend_info send_info = {};
> -	int ret;
> 
>  	send_info.write.addr = (uintptr_t)action->rewrite->data;
>  	send_info.write.length = action->rewrite->num_of_actions *
> @@ -734,9 +733,7 @@ int mlx5dr_send_postsend_action(struct mlx5dr_domain *dmn,
>  		mlx5dr_icm_pool_get_chunk_mr_addr(action->rewrite->chunk);
>  	send_info.rkey = mlx5dr_icm_pool_get_chunk_rkey(action->rewrite->chunk);
> 
> -	ret = dr_postsend_icm_data(dmn, &send_info);
> -
> -	return ret;
> +	return dr_postsend_icm_data(dmn, &send_info);
>  }
> 
>  static int dr_modify_qp_rst2init(struct mlx5_core_dev *mdev,


Reviewed-by: Roi Dayan <roid@...dia.com>