[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a2458e6a-6b19-cd67-2b84-5cef6388e011@linaro.org>
Date: Mon, 5 Dec 2022 09:17:24 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Kees Cook <keescook@...omium.org>
Cc: syzbot+210e196cef4711b65139@...kaller.appspotmail.com,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
"John W. Linville" <linville@...driver.com>,
Ilan Elias <ilane@...com>, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org
Subject: Re: [PATCH] NFC: nci: Bounds check struct nfc_target arrays
On 02/12/2022 22:44, Kees Cook wrote:
> While running under CONFIG_FORTIFY_SOURCE=y, syzkaller reported:
>
> memcpy: detected field-spanning write (size 129) of single field "target->sensf_res" at net/nfc/nci/ntf.c:260 (size 18)
>
> This appears to be a legitimate lack of bounds checking in
> nci_add_new_protocol(). Add the missing checks.
>
> Reported-by: syzbot+210e196cef4711b65139@...kaller.appspotmail.com
> Link: https://lore.kernel.org/lkml/0000000000001c590f05ee7b3ff4@google.com
> Fixes: 019c4fbaa790 ("NFC: Add NCI multiple targets support")
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: netdev@...r.kernel.org
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Best regards,
Krzysztof
Powered by blists - more mailing lists