linux-kernel - Re: [PATCH] can: can327: Flush tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221205084556.etpo2xufbsl5753d@pengutronix.de>
Date:   Mon, 5 Dec 2022 09:45:56 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Max Staudt <max@...as.org>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Vincent Mailhol <vincent.mailhol@...il.com>,
        Oliver Neukum <oneukum@...e.com>, linux-kernel@...r.kernel.org,
        "Jiri Slaby (SUSE)" <jirislaby@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] can: can327: Flush tx_work on ldisc .close()

On 03.12.2022 01:01:48, Max Staudt wrote:
> Additionally, remove it from .ndo_stop().
> 
> This ensures that the worker is not called after being freed, and that
> the UART TX queue remains active to send final commands when the netdev
> is stopped.
> 
> Thanks to Jiri Slaby for finding this in slcan:
> 
>   https://lore.kernel.org/linux-can/20221201073426.17328-1-jirislaby@kernel.org/
> 
> A variant of this patch for slcan, with the flush in .ndo_stop() still
> present, has been tested successfully on physical hardware:
> 
>   https://bugzilla.suse.com/show_bug.cgi?id=1205597
> 
> Fixes: 43da2f07622f ("can: can327: CAN/ldisc driver for ELM327 based OBD-II adapters")
> Cc: "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
> Cc: Max Staudt <max@...as.org>
> Cc: Wolfgang Grandegger <wg@...ndegger.com>
> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: linux-can@...r.kernel.org
> Cc: netdev@...r.kernel.org
> Cc: stable@...r.kernel.org
> Signed-off-by: Max Staudt <max@...as.org>

Applied to linux-can.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)