linux-kernel - Re: [PATCH linux-next v3] fbdev: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdV=ryCjskpYeh8vCo+ZUapuNBNFS22JktxARy+1XgSEtQ@mail.gmail.com>
Date:   Mon, 5 Dec 2022 09:47:08 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     ye.xingchen@....com.cn
Cc:     deller@....de, javierm@...hat.com, tzimmermann@...e.de,
        geert+renesas@...der.be, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH linux-next v3] fbdev: use sysfs_emit() to instead of scnprintf()

Hi Ye,

Thanks for your patch!

On Mon, Dec 5, 2022 at 9:31 AM <ye.xingchen@....com.cn> wrote:
> From: ye xingchen <ye.xingchen@....com.cn>
>
> Follow the advice of the Documentation/filesystems/sysfs.rst and show()
> should only use sysfs_emit() or sysfs_emit_at() when formatting the
> value to be returned to user space.
>
> Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
> ---
> v2 -> v3
> Fix the mistakes in v2.

Indeed, that's usually what a v3 does ;-)
It would help if you listed the actual changes instead.

But "b4 diff 202212051631391777945@....com.cn" doesn't show any?

Thanks!

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds