linux-kernel - Re: [PATCH v3 9/9] mfd: intel-m10-bmc: Change MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 11:05:44 +0200 (EET)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Greg KH <gregkh@...uxfoundation.org>
cc:     linux-fpga@...r.kernel.org, Xu Yilun <yilun.xu@...el.com>,
        Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
        Moritz Fischer <mdf@...nel.org>, Lee Jones <lee@...nel.org>,
        Matthew Gerlach <matthew.gerlach@...ux.intel.com>,
        Russ Weight <russell.h.weight@...el.com>,
        Tianfei zhang <tianfei.zhang@...el.com>,
        Mark Brown <broonie@...nel.org>,
        Marco Pagani <marpagan@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 9/9] mfd: intel-m10-bmc: Change MODULE_LICENSE() to
 GPL

On Sun, 4 Dec 2022, Greg KH wrote:

> On Fri, Dec 02, 2022 at 12:08:41PM +0200, Ilpo Järvinen wrote:
> > "GPL v2" should not be used as MODULE_LICENSE(). "GPL" is enough, see
> > commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL
> > v2" bogosity") for more details.
> 
> And that commit says that leaving "GPL v2" is just fine and dandy and
> should not be an issue at all.

>From reading just it's changelog, it's hard to come into that conclusion
(in fact, the opposite reading is very much crafted into many of the 
wordings in the changelog, e.g., stating that "GPL" is "completely 
sufficient" and that other ways assume wrongly distinction, etc.).

Only after reading now the diff itself, I can see that being the case.

> Please do not change the license for no good reason.  That commit is NOT
> a good reason to change it at all.
> 
> so NAK on this patch, sorry.

Okay, I'm certainly fine dropping it :-).

The reason why I added this change was checkpatch giving this:

WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: 
Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")

...And bf7fbeeae6db's changelog then further reinforced that "GPL" is 
sufficient.

I guess checkpatch wanted to give the warning only for new stuff but 
since I was moving code around it misdetected the moved bits as new.


-- 
 i.