linux-kernel - Re: [PATCH v6 4/5] media: i2c: imx334: support lower bandwidth mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202212051635.fMvCkQmC-lkp@intel.com>
Date:   Mon, 5 Dec 2022 17:11:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     shravan kumar <shravan.chippa@...rochip.com>,
        paul.j.murphy@...el.com, daniele.alessandrelli@...el.com,
        mchehab@...nel.org
Cc:     oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Shravan Chippa <shravan.chippa@...rochip.com>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Prakash Battu <Prakash.Battu@...rochip.com>
Subject: Re: [PATCH v6 4/5] media: i2c: imx334: support lower bandwidth mode

Hi shravan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on linus/master v6.1-rc8 next-20221205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/shravan-kumar/media-i2c-imx334-support-lower-bandwidth-mode/20221205-132242
base:   git://linuxtv.org/media_tree.git master
patch link:    https://lore.kernel.org/r/20221205051937.3897001-6-shravan.chippa%40microchip.com
patch subject: [PATCH v6 4/5] media: i2c: imx334: support lower bandwidth mode
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/40bcaa9326e82b14f5691eb1d81c4a2d01eca8df
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review shravan-kumar/media-i2c-imx334-support-lower-bandwidth-mode/20221205-132242
        git checkout 40bcaa9326e82b14f5691eb1d81c4a2d01eca8df
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/media/i2c/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/media/i2c/imx334.c: In function 'imx334_enum_frame_size':
>> drivers/media/i2c/imx334.c:767:22: warning: unused variable 'i' [-Wunused-variable]
     767 |         unsigned int i;
         |                      ^


vim +/i +767 drivers/media/i2c/imx334.c

   753	
   754	/**
   755	 * imx334_enum_frame_size() - Enumerate V4L2 sub-device frame sizes
   756	 * @sd: pointer to imx334 V4L2 sub-device structure
   757	 * @sd_state: V4L2 sub-device state
   758	 * @fsize: V4L2 sub-device size enumeration need to be filled
   759	 *
   760	 * Return: 0 if successful, error code otherwise.
   761	 */
   762	static int imx334_enum_frame_size(struct v4l2_subdev *sd,
   763					  struct v4l2_subdev_state *sd_state,
   764					  struct v4l2_subdev_frame_size_enum *fsize)
   765	{
   766		struct imx334 *imx334 = to_imx334(sd);
 > 767		unsigned int i;
   768		u32 code;
   769	
   770		if (fsize->index >= ARRAY_SIZE(supported_modes))
   771			return -EINVAL;
   772	
   773		mutex_lock(&imx334->mutex);
   774		code = imx334_get_format_code(imx334, fsize->code);
   775		mutex_unlock(&imx334->mutex);
   776		if (fsize->code != code)
   777			return -EINVAL;
   778	
   779		fsize->min_width = supported_modes[fsize->index].width;
   780		fsize->max_width = fsize->min_width;
   781		fsize->min_height = supported_modes[fsize->index].height;
   782		fsize->max_height = fsize->min_height;
   783	
   784		return 0;
   785	}
   786	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (291948 bytes)