linux-kernel - Re: [PATCH] trace: Fix some checker warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <382387.1670235778@warthog.procyon.org.uk>
Date:   Mon, 05 Dec 2022 10:22:58 +0000
From:   David Howells <dhowells@...hat.com>
To:     Masami Hiramatsu (Google) <mhiramat@...nel.org>
Cc:     dhowells@...hat.com, rostedt@...dmis.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] trace: Fix some checker warnings

Masami Hiramatsu (Google) <mhiramat@...nel.org> wrote:

> Could you remove that part from your printf checker macro, and
> apply the below patch?
> Since the printf macros are a kind of improvement but this part is an
> actual bug, need to be fixed on stable kernel too.

Sure.  Posted that as v2.

> From 2e993ec80d864677fd42d27f9d4ee01d7e63f8a4 Mon Sep 17 00:00:00 2001
> From: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
> Date: Mon, 5 Dec 2022 14:27:00 +0900
> Subject: [PATCH] tracing: Fix complicated dependency of
>  CONFIG_TRACER_MAX_TRACE
> 
> Both CONFIG_OSNOISE_TRACER and CONFIG_HWLAT_TRACER partially enables the
> CONFIG_TRACER_MAX_TRACE code, but that is complicated and has
> introduced a bug; It declares tracing_max_lat_fops data structure outside
> of #ifdefs, but since it is defined only when CONFIG_TRACER_MAX_TRACE=y
> or CONFIG_HWLAT_TRACER=y, if only CONFIG_OSNOISE_TRACER=y, that
> declaration comes to a definition(!).
> 
> To fix this issue, and do not repeat the similar problem, makes
> CONFIG_OSNOISE_TRACER and CONFIG_HWLAT_TRACER enables the
> CONFIG_TRACER_MAX_TRACE always. It has there benefits;
> - Fix the tracing_max_lat_fops bug
> - Simplify the #ifdefs
> - CONFIG_TRACER_MAX_TRACE code is fully enabled, or not.
> 
> Fixes: 424b650f35c7 ("tracing: Fix missing osnoise tracer on max_latency")
> Cc: stable@...r.kernel.org
> Reported-by: David Howells <dhowells@...hat.com>
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>

Tested-by: David Howells <dhowells@...hat.com>