linux-kernel - Re: [PATCH] KVM: x86: remove unnecessary exports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <05188606-395e-acd0-b821-2526d5808aca@gmail.com>
Date:   Mon, 5 Dec 2022 19:13:19 +0800
From:   Like Xu <like.xu.linux@...il.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Sean Christopherson <seanjc@...gle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: x86: remove unnecessary exports

On 3/12/2022 2:37 am, Paolo Bonzini wrote:
> --- a/arch/x86/kvm/hyperv.c
> +++ b/arch/x86/kvm/hyperv.c
> @@ -898,7 +898,6 @@ bool kvm_hv_assist_page_enabled(struct kvm_vcpu *vcpu)
>   		return false;
>   	return vcpu->arch.pv_eoi.msr_val & KVM_MSR_ENABLED;
>   }
> -EXPORT_SYMBOL_GPL(kvm_hv_assist_page_enabled);

The kvm_hv_verify_vp_assist() is used in svm object where 
kvm_hv_assist_page_enabled() is called,
so the deletion of this line now brings a link failure. The first version of the 
patch set did not catch
such a simple error, and I assume another discussion thread's in-flight changes 
were merged into.

We may add this line back to easily fix this merge conflict.