[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212051928467539184@zte.com.cn>
Date: Mon, 5 Dec 2022 19:28:46 +0800 (CST)
From: <yang.yang29@....com.cn>
To: <w.d.hubbs@...il.com>
Cc: <chris@...-brannons.com>, <kirk@...sers.ca>,
<samuel.thibault@...-lyon.org>, <mushi.shar@...il.com>,
<speakup@...ux-speakup.org>, <linux-kernel@...r.kernel.org>,
<xu.panda@....com.cn>, <yang.yang29@....com.cn>
Subject: [PATCH linux-next v2] accessibility: speakup: use strscpy() to instead of strncpy()
From: Xu Panda <xu.panda@....com.cn>
The implementation of strscpy() is more robust and safer.
That's now the recommended way to copy NUL terminated strings.
---
change for v2
- fix the mistake of eating one character when len > 250,
thanks to Samuel Thibault.
---
Signed-off-by: Xu Panda <xu.panda@....com.cn>
Signed-off-by: Yang Yang <yang.yang29@....com>
Signed-off-by: Samuel Thibault <samuel.thibault@...-lyon.org>
---
drivers/accessibility/speakup/kobjects.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/accessibility/speakup/kobjects.c b/drivers/accessibility/speakup/kobjects.c
index a7522d409802..c1ef48280f3c 100644
--- a/drivers/accessibility/speakup/kobjects.c
+++ b/drivers/accessibility/speakup/kobjects.c
@@ -426,8 +426,7 @@ static ssize_t synth_direct_store(struct kobject *kobj,
spin_lock_irqsave(&speakup_info.spinlock, flags);
while (len > 0) {
bytes = min_t(size_t, len, 250);
- strncpy(tmp, ptr, bytes);
- tmp[bytes] = '\0';
+ strscpy(tmp, ptr, bytes + 1);
string_unescape_any_inplace(tmp);
synth_printf("%s", tmp);
ptr += bytes;
--
2.15.2
Powered by blists - more mailing lists