[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4411cfd9-7286-32fd-2032-622caa099e91@collabora.com>
Date: Mon, 5 Dec 2022 13:47:40 +0100
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Yanchao Yang (杨彦超)
<Yanchao.Yang@...iatek.com>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"ryazanov.s.a@...il.com" <ryazanov.s.a@...il.com>,
"kuba@...nel.org" <kuba@...nel.org>,
"loic.poulain@...aro.org" <loic.poulain@...aro.org>,
"edumazet@...gle.com" <edumazet@...gle.com>,
"pabeni@...hat.com" <pabeni@...hat.com>,
"johannes@...solutions.net" <johannes@...solutions.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"davem@...emloft.net" <davem@...emloft.net>
Cc: Chris Feng (冯保林)
<Chris.Feng@...iatek.com>,
"linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>,
Mingliang Xu (徐明亮)
<mingliang.xu@...iatek.com>,
"linuxwwan@...iatek.com" <linuxwwan@...iatek.com>,
Min Dong (董敏) <min.dong@...iatek.com>,
"linuxwwan@...el.com" <linuxwwan@...el.com>,
"m.chetan.kumar@...el.com" <m.chetan.kumar@...el.com>,
Liang Lu (吕亮) <liang.lu@...iatek.com>,
Haijun Liu (刘海军)
<haijun.liu@...iatek.com>,
Haozhe Chang (常浩哲)
<Haozhe.Chang@...iatek.com>,
Hua Yang (杨华) <Hua.Yang@...iatek.com>,
Xiayu Zhang (张夏宇)
<Xiayu.Zhang@...iatek.com>,
Aiden Wang (王咏麒)
<Aiden.Wang@...iatek.com>,
Felix Chen (陈非) <Felix.Chen@...iatek.com>,
Ting Wang (王挺) <ting.wang@...iatek.com>,
Guohao Zhang (张国豪)
<Guohao.Zhang@...iatek.com>,
Mingchuang Qiao (乔明闯)
<Mingchuang.Qiao@...iatek.com>,
Lambert Wang (王伟)
<Lambert.Wang@...iatek.com>
Subject: Re: [PATCH net-next v1 01/13] net: wwan: tmi: Add PCIe core
Il 05/12/22 13:40, Yanchao Yang (杨彦超) ha scritto:
> On Thu, 2022-11-24 at 12:06 +0100, AngeloGioacchino Del Regno wrote:
>> Il 22/11/22 12:11, Yanchao Yang ha scritto:
>>> From: MediaTek Corporation <linuxwwan@...iatek.com>
>>>
>>> Registers the TMI device driver with the kernel. Set up all the
>>> fundamental
>>> configurations for the device: PCIe layer, Modem Host Cross Core
>>> Interface
>>> (MHCCIF), Reset Generation Unit (RGU), modem common control
>>> operations and
>>> build infrastructure.
>>>
>>> * PCIe layer code implements driver probe and removal, MSI-X
>>> interrupt
>>> initialization and de-initialization, and the way of resetting the
>>> device.
>>> * MHCCIF provides interrupt channels to communicate events such as
>>> handshake,
>>> PM and port enumeration.
>>> * RGU provides interrupt channels to generate notifications from
>>> the device
>>> so that the TMI driver could get the device reset.
>>> * Modem common control operations provide the basic read/write
>>> functions of
>>> the device's hardware registers, mask/unmask/get/clear functions of
>>> the
>>> device's interrupt registers and inquiry functions of the device's
>>> status.
>>>
>>> Signed-off-by: Ting Wang <ting.wang@...iatek.com>
>>> Signed-off-by: MediaTek Corporation <linuxwwan@...iatek.com>
>
> Hello Angelo,
>
>> Hello Yanchao,
>> thanks for the patch! However, there are some things to improve...
>>
>> First of all, you have to signoff (in your name) all patches that you
>> send.
>
> Thank your suggestion. Fix it next version (add Signed-off-by: Yanchao
> Yang <yanchao.yang@...iatek.com> for all patches)
>> Check below for more comments...
>>
>>> ---
..snip.. :-)
There's a misunderstanding here: when I write
"..snip.."
I mean "I'm snipping out lines of code for which I have no comments, or
for which comments are redundant"
I do that to increase readability of reviews and decrease the size of the
mail that's going out, nothing else.
>>
>>> + u32 (*read32)(struct mtk_md_dev *mdev, u64 addr);
>>
>> ..snip..
>
> do you mean we should remove read function wrapper?
No, that's fine.
Regards,
Angelo
Powered by blists - more mailing lists