linux-kernel - Re: [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of strncpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y43rDpYejtOcne3+@minyard.net>
Date:   Mon, 5 Dec 2022 06:58:54 -0600
From:   Corey Minyard <minyard@....org>
To:     yang.yang29@....com.cn
Cc:     openipmi-developer@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, xu.panda@....com.cn
Subject: Re: [PATCH linux-next] ipmi/watchdog: use strscpy() to instead of
 strncpy()

On Mon, Dec 05, 2022 at 07:36:40PM +0800, yang.yang29@....com.cn wrote:
> Xu Panda <xu.panda@....com.cn>
> 
> The implementation of strscpy() is more robust and safer.
> That's now the recommended way to copy NUL terminated strings.

This looks right.  Applied, thanks.

-corey

> 
> Signed-off-by: Xu Panda <xu.panda@....com.cn>
> Signed-off-by: Yang Yang <yang.yang29@....com>
> ---
>  drivers/char/ipmi/ipmi_watchdog.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
> index 47365150e431..0d4a8dcacfd4 100644
> --- a/drivers/char/ipmi/ipmi_watchdog.c
> +++ b/drivers/char/ipmi/ipmi_watchdog.c
> @@ -213,8 +213,7 @@ static int set_param_str(const char *val, const struct kernel_param *kp)
>  	char       valcp[16];
>  	char       *s;
> 
> -	strncpy(valcp, val, 15);
> -	valcp[15] = '\0';
> +	strscpy(valcp, val, 16);
> 
>  	s = strstrip(valcp);
> 
> -- 
> 2.15.2