[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <202212051021451139126@zte.com.cn>
Date: Mon, 5 Dec 2022 10:21:45 +0800 (CST)
From: <ye.xingchen@....com.cn>
To: <leon@...nel.org>, <davem@...emloft.net>
Cc: <ecree.xilinx@...il.com>, <habetsm.xilinx@...il.com>,
<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
<petrm@...dia.com>, <khalasa@...p.pl>, <shayagr@...zon.com>,
<wsa+renesas@...g-engineering.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: [PATCH net-next v2] sfc: use sysfs_emit() to instead of scnprintf()
From: ye xingchen <ye.xingchen@....com.cn>
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.
Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
v1 -> v2
Fix the Subject.
drivers/net/ethernet/sfc/efx_common.c | 2 +-
drivers/net/ethernet/sfc/siena/efx_common.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx_common.c b/drivers/net/ethernet/sfc/efx_common.c
index c2224e41a694..cc30524c2fe4 100644
--- a/drivers/net/ethernet/sfc/efx_common.c
+++ b/drivers/net/ethernet/sfc/efx_common.c
@@ -1164,7 +1164,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
struct efx_nic *efx = dev_get_drvdata(dev);
struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
- return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
+ return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
}
static ssize_t mcdi_logging_store(struct device *dev,
diff --git a/drivers/net/ethernet/sfc/siena/efx_common.c b/drivers/net/ethernet/sfc/siena/efx_common.c
index 1fd396b00bfb..e4b294b8e9ac 100644
--- a/drivers/net/ethernet/sfc/siena/efx_common.c
+++ b/drivers/net/ethernet/sfc/siena/efx_common.c
@@ -1178,7 +1178,7 @@ static ssize_t mcdi_logging_show(struct device *dev,
struct efx_nic *efx = dev_get_drvdata(dev);
struct efx_mcdi_iface *mcdi = efx_mcdi(efx);
- return scnprintf(buf, PAGE_SIZE, "%d\n", mcdi->logging_enabled);
+ return sysfs_emit(buf, "%d\n", mcdi->logging_enabled);
}
static ssize_t mcdi_logging_store(struct device *dev,
--
2.25.1
Powered by blists - more mailing lists