linux-kernel - Re: [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP OCM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <330f1b49-eb59-c55e-3f7d-dfbf4886f247@amd.com>
Date:   Mon, 5 Dec 2022 15:49:33 +0100
From:   Michal Simek <michal.simek@....com>
To:     Borislav Petkov <bp@...en8.de>,
        "Potthuri, Sai Krishna" <sai.krishna.potthuri@....com>
CC:     Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Michal Simek <michal.simek@...inx.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Tony Luck <tony.luck@...el.com>,
        James Morse <james.morse@....com>,
        Robert Richter <rric@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
        "saikrishna12468@...il.com" <saikrishna12468@...il.com>,
        "git (AMD-Xilinx)" <git@....com>,
        "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH v6 2/2] EDAC/zynqmp: Add EDAC support for Xilinx ZynqMP
 OCM



On 12/5/22 14:16, Borislav Petkov wrote:
> On Mon, Dec 05, 2022 at 10:20:11AM +0000, Potthuri, Sai Krishna wrote:
>> As we communicated earlier for ZynqMP platform we have both Synopsys
>> (for DDRMC) and zynqmp_ocm_edac (for OCM) drivers. Just to be clear
>> about what this driver is targeted for, we used ocm as part of file
>> name. Ok, zynqmp_edac.c looks fine, will update.
> 
> Yeah, we can always rename later, when another driver is needed. For
> now, let's keep things simple.
> 
>> Ok, will update API documentation like below.
>> echo <fault_injection count> > /sys/kernel/debug/edac/ff960000.memory-controller/inject_fault_count
> 							^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Any particular reason this should not be called simply "mc0" or so?
> 
> At least this is how we call them on x86...

Some history around this. Based on
https://github.com/devicetree-org/devicetree-specification/releases/download/v0.3/devicetree-specification-v0.3.pdf
Chapter 2.2.2 Generic Names Recommendation
memory-controller name is recommended.

Thanks,
Michal