Message-Id: <20221205150116.1064295-1-Jason@zx2c4.com>
Date:   Mon,  5 Dec 2022 16:01:16 +0100
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org
Subject: [GIT PULL] -funsigned-char conversion for 6.2-rc1

Hi Linus,

Please pull the following tree, which contains the change to use
-funsigned-char, in addition to fixes to code that made different assumptions
about the signedness of chars.

During the 6.1 cycle, several patches already made it to your tree, which were
for code that was already broken on at least one architecture, where the naked
char had a different sign than the code author anticipated, or were part of
some bug fix for an existing bug that this initiative unearthed. These 6.1-era
fixes are:

- 648060902aa3 MIPS: pic32: treat port as signed integer
- 5c26159c97b3 ipvs: use explicitly signed chars
- e6cb8769452e wifi: airo: do not assign -1 to unsigned char
- 937ec9f7d5f2 staging: rtl8192e: remove bogus ssid character sign test
- 677047383296 misc: sgi-gru: use explicitly signed char
- 50895a55bcfd ALSA: rme9652: use explicitly signed char
- ee03c0f200eb ALSA: au88x0: use explicitly signed char
- 835bed1b8395 fbdev: sisfb: use explicitly signed char
- 50f19697dd76 parisc: Use signed char for hardware path in pdc.h
- 66063033f77e wifi: rt2x00: use explicitly signed or unsigned types

Regarding patches in this pull:

- There is one patch in this pull that should have made it to you during 6.1
  ("media: stv0288: use explicitly signed char"), but the maintainer was MIA
  during the cycle, so it's in here instead.

- Two patches fix single architecture code affected by -funsigned-char
  ("perf/x86: Make struct p4_event_bind::cntr signed array" and "sparc: sbus:
  treat CPU index as integer"), while one patch fixes an unused typedef, in
  case it's ever used in the future ("media: atomisp: make hive_int8 explictly
  signed").

- Finally, there's the change to actually enable -funsigned-char ("kbuild:
  treat char as always unsigned") and then the removal of some no longer
  useful !__CHAR_UNSIGNED__ selftest code ("lib: assume char is unsigned").

The various fixes were found with a combination of diffing objdump output, a
large variety of Coccinelle scripts, and plain old grep. In the end, things
didn't seem as bad as I feared they would. But of course, it's also possible I
missed things. However, this has been in linux-next for basically an entire
cycle now, so I'm not overly worried. I've also been daily driving this on my
laptop for all of 6.1. Still, this series, and the ones sent for 6.1 don't
total in quantity to what I thought it'd be, so I will be on the lookout for
breakage.

We could receive a few reports that are quickly fixable. Hopefully we won't
receive a barrage of reports that would result in a revert. And just maybe we
won't receive any reports at all and nobody will even notice. Knock on wood.

Please pull!

Thanks,
Jason


The following changes since commit 23a60a03d9a9980d1e91190491ceea0dc58fae62:

  Merge tag 'arm64-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux (2022-11-18 14:31:03 -0800)

are available in the Git repository at:

  https://git.kernel.org/pub/scm/linux/kernel/git/zx2c4/linux.git tags/unsigned-char-6.2-for-linus

for you to fetch changes up to 0445d1bae1cce00ae4e99c8cde33784a8199bad6:

  lib: assume char is unsigned (2022-11-19 00:56:15 +0100)

----------------------------------------------------------------
Enable -funsigned-char and fix code affected by that flag.
----------------------------------------------------------------

Alexey Dobriyan (1):
      perf/x86: Make struct p4_event_bind::cntr signed array

Jason A. Donenfeld (5):
      sparc: sbus: treat CPU index as integer
      media: stv0288: use explicitly signed char
      media: atomisp: make hive_int8 explictly signed
      kbuild: treat char as always unsigned
      lib: assume char is unsigned

 Makefile                                       |  2 +-
 arch/x86/events/intel/p4.c                     |  2 +-
 drivers/media/dvb-frontends/stv0288.c          |  5 ++---
 drivers/sbus/char/envctrl.c                    |  4 ++--
 drivers/staging/media/atomisp/pci/hive_types.h |  2 +-
 lib/is_signed_type_kunit.c                     |  4 ----
 lib/test_printf.c                              | 12 ------------
 7 files changed, 7 insertions(+), 24 deletions(-)

Powered by blists - more mailing lists