| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202212052329.ptXCY8NP-lkp@intel.com>
Date: Mon, 5 Dec 2022 23:40:41 +0800
From: kernel test robot <lkp@...el.com>
To: Huacai Chen <chenhuacai@...ngson.cn>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
WANG Xuerui <git@...0n.name>,
Jianmin Lv <lvjianmin@...ngson.cn>
Subject: drivers/net/wireless/intel/iwlegacy/4965-rs.c:1636:25: warning:
variable 'il' set but not used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 76dcd734eca23168cb008912c0f69ff408905235
commit: 57fc7323a8e7c2e7c1d5795ab63cb3ffea3cfdfb LoongArch: Add PCI controller support
date: 4 months ago
config: loongarch-randconfig-r035-20221205
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=57fc7323a8e7c2e7c1d5795ab63cb3ffea3cfdfb
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 57fc7323a8e7c2e7c1d5795ab63cb3ffea3cfdfb
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/net/wireless/intel/iwlegacy/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
drivers/net/wireless/intel/iwlegacy/4965-rs.c: In function 'il4965_rs_stay_in_table':
>> drivers/net/wireless/intel/iwlegacy/4965-rs.c:1636:25: warning: variable 'il' set but not used [-Wunused-but-set-variable]
1636 | struct il_priv *il;
| ^~
drivers/net/wireless/intel/iwlegacy/4965-rs.c: In function 'il4965_rs_alloc_sta':
drivers/net/wireless/intel/iwlegacy/4965-rs.c:2257:25: warning: variable 'il' set but not used [-Wunused-but-set-variable]
2257 | struct il_priv *il;
| ^~
drivers/net/wireless/intel/iwlegacy/4965-rs.c: In function 'il4965_rs_sta_dbgfs_scale_table_write':
drivers/net/wireless/intel/iwlegacy/4965-rs.c:2535:25: warning: variable 'il' set but not used [-Wunused-but-set-variable]
2535 | struct il_priv *il;
| ^~
vim +/il +1636 drivers/net/wireless/intel/iwlegacy/4965-rs.c
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1621
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1622 /*
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1623 * Check whether we should continue using same modulation mode, or
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1624 * begin search for a new mode, based on:
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1625 * 1) # tx successes or failures while using this mode
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1626 * 2) # times calling this function
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1627 * 3) elapsed time in this mode (not used, for now)
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1628 */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1629 static void
e2ebc8337d116a drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-10-24 1630 il4965_rs_stay_in_table(struct il_lq_sta *lq_sta, bool force_search)
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1631 {
e2ebc8337d116a drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-10-24 1632 struct il_scale_tbl_info *tbl;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1633 int i;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1634 int active_tbl;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1635 int flush_interval_passed = 0;
46bc8d4b0e73ac drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-10-24 @1636 struct il_priv *il;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1637
46bc8d4b0e73ac drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-10-24 1638 il = lq_sta->drv;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1639 active_tbl = lq_sta->active_tbl;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1640
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1641 tbl = &(lq_sta->lq_info[active_tbl]);
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1642
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1643 /* If we've been disallowing search, see if we should now allow it */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1644 if (lq_sta->stay_in_tbl) {
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1645
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1646 /* Elapsed time using current modulation mode */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1647 if (lq_sta->flush_timer)
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1648 flush_interval_passed =
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1649 time_after(jiffies,
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1650 (unsigned long)(lq_sta->flush_timer +
2eb058162ea8b7 drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1651 RATE_SCALE_FLUSH_INTVL));
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1652
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1653 /*
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1654 * Check if we should allow search for new modulation mode.
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1655 * If many frames have failed or succeeded, or we've used
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1656 * this same modulation for a long time, allow search, and
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1657 * reset history stats that keep track of whether we should
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1658 * allow a new search. Also (below) reset all bitmaps and
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1659 * stats in active history.
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1660 */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1661 if (force_search ||
232913b51e6f6e drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1662 lq_sta->total_failed > lq_sta->max_failure_limit ||
232913b51e6f6e drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1663 lq_sta->total_success > lq_sta->max_success_limit ||
232913b51e6f6e drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1664 (!lq_sta->search_better_tbl && lq_sta->flush_timer &&
232913b51e6f6e drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1665 flush_interval_passed)) {
ff5e56859d3887 drivers/net/wireless/iwlegacy/4965-rs.c Geert Uytterhoeven 2015-03-03 1666 D_RATE("LQ: stay is expired %d %d %d\n",
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1667 lq_sta->total_failed, lq_sta->total_success,
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1668 flush_interval_passed);
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1669
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1670 /* Allow search for new mode */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1671 lq_sta->stay_in_tbl = 0; /* only place reset */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1672 lq_sta->total_failed = 0;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1673 lq_sta->total_success = 0;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1674 lq_sta->flush_timer = 0;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1675
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1676 /*
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1677 * Else if we've used this modulation mode enough repetitions
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1678 * (regardless of elapsed time or success/failure), reset
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1679 * history bitmaps and rate-specific stats for all rates in
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1680 * active table.
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1681 */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1682 } else {
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1683 lq_sta->table_count++;
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1684 if (lq_sta->table_count >= lq_sta->table_count_limit) {
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1685 lq_sta->table_count = 0;
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1686
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1687 D_RATE("LQ: stay in table clear win\n");
2eb058162ea8b7 drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1688 for (i = 0; i < RATE_COUNT; i++)
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1689 il4965_rs_rate_scale_clear_win(&
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1690 (tbl->
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1691 win
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1692 [i]));
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1693 }
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1694 }
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1695
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1696 /* If transitioning to allow "search", reset all history
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1697 * bitmaps and stats in active table (this will become the new
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1698 * "search" table). */
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1699 if (!lq_sta->stay_in_tbl) {
2eb058162ea8b7 drivers/net/wireless/iwlegacy/iwl-4965-rs.c Stanislaw Gruszka 2011-08-26 1700 for (i = 0; i < RATE_COUNT; i++)
e7392364fcd100 drivers/net/wireless/iwlegacy/4965-rs.c Stanislaw Gruszka 2011-11-15 1701 il4965_rs_rate_scale_clear_win(&(tbl->win[i]));
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1702 }
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1703 }
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1704 }
be663ab67077fa drivers/net/wireless/iwlegacy/iwl-4965-rs.c Wey-Yi Guy 2011-02-21 1705
:::::: The code at line 1636 was first introduced by commit
:::::: 46bc8d4b0e73ac75de323646d75a2333f47b84c3 iwlegacy: rename priv to il
:::::: TO: Stanislaw Gruszka <sgruszka@...hat.com>
:::::: CC: Stanislaw Gruszka <sgruszka@...hat.com>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
View attachment "config" of type "text/plain" (176516 bytes)
Powered by blists - more mailing lists