linux-kernel - Re: [PATCH bpf-next v2] selftests/bpf: Fix conflicts with built-in functions in bpf_iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <167020981514.9466.9589871832936994836.git-patchwork-notify@kernel.org>
Date:   Mon, 05 Dec 2022 03:10:15 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     James Hilliard <james.hilliard1@...il.com>
Cc:     bpf@...r.kernel.org, andrii@...nel.org, ast@...nel.org,
        daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
        sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
        mykolal@...com, shuah@...nel.org, alan.maguire@...cle.com,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH bpf-next v2] selftests/bpf: Fix conflicts with built-in
 functions in bpf_iter_ksym

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@...nel.org>:

On Fri,  2 Dec 2022 18:08:44 -0700 you wrote:
> Both tolower and toupper are built in c functions, we should not
> redefine them as this can result in a build error.
> 
> Fixes the following errors:
> progs/bpf_iter_ksym.c:10:20: error: conflicting types for built-in function 'tolower'; expected 'int(int)' [-Werror=builtin-declaration-mismatch]
>    10 | static inline char tolower(char c)
>       |                    ^~~~~~~
> progs/bpf_iter_ksym.c:5:1: note: 'tolower' is declared in header '<ctype.h>'
>     4 | #include <bpf/bpf_helpers.h>
>   +++ |+#include <ctype.h>
>     5 |
> progs/bpf_iter_ksym.c:17:20: error: conflicting types for built-in function 'toupper'; expected 'int(int)' [-Werror=builtin-declaration-mismatch]
>    17 | static inline char toupper(char c)
>       |                    ^~~~~~~
> progs/bpf_iter_ksym.c:17:20: note: 'toupper' is declared in header '<ctype.h>'
> 
> [...]

Here is the summary with links:
  - [bpf-next,v2] selftests/bpf: Fix conflicts with built-in functions in bpf_iter_ksym
    https://git.kernel.org/bpf/bpf-next/c/ab0350c743d5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html