linux-kernel - Re: [PATCH v6 5/5] drivers: Implement module modaliases for USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Dec 2022 16:53:10 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Allen Webb <allenwebb@...gle.com>
Cc:     "linux-modules@...r.kernel.org" <linux-modules@...r.kernel.org>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Luis Chamberlain <mcgrof@...nel.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v6 5/5] drivers: Implement module modaliases for USB

On Fri, Dec 02, 2022 at 04:47:44PM -0600, Allen Webb wrote:
> Add the per-subsystem logic needed to print match-based modaliases to
> the USB subsystem, so the modalias sysfs attribute for modules will
> function for modules that register USB drivers.
> 
> Signed-off-by: Allen Webb <allenwebb@...gle.com>
> ---
>  drivers/base/Makefile          |   2 +-
>  drivers/base/base.h            |   8 +
>  drivers/base/mod_devicetable.c | 257 +++++++++++++++++++++++++++++++++
>  drivers/usb/core/driver.c      |   2 +

It feels like you have a lot of USB-specific stuff here in the driver
core, and not enough in the usb core.  How is each different bus going
to do this?  Add code to the driver core?  It should be able to not
touch the driver core at all to add support for this for a new bus.

thanks,

greg k-h